Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML-DSA (FIPS204) #480

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Add ML-DSA (FIPS204) #480

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
62302ce
[WIP] Add ML-DSA (FIPS204)
bwesterb Feb 15, 2024
bf96f6e
dilithium: fix typo in privkey size panic
bwesterb Feb 28, 2024
3b018a4
Update to final FIPS 204 standard.
bwesterb Aug 20, 2024
ecf1196
ML-DSA test against reference implementation.
bwesterb Sep 25, 2024
63eb44c
dilithium: remove unused AES code
bwesterb Oct 8, 2024
f1674c7
mldsa: add ACVP test vectors
bwesterb Oct 8, 2024
a43f90b
Remove superfluous space
bwesterb Oct 8, 2024
0169792
Update ml-dsa documentation
bwesterb Oct 8, 2024
bef2502
Remove dead code
bwesterb Oct 8, 2024
d55a0aa
Avoid to export unsafeSignInternal.
armfazh Oct 9, 2024
dcffd66
Update command for golangci-lint.
armfazh Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid to export unsafeSignInternal.
  • Loading branch information
@armfazh
armfazh committed Oct 9, 2024
commit d55a0aacd1ce94c093c3f16adb27db709e45d586
35 changes: 35 additions & 0 deletions sign/dilithium/gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ var (

func main() {
generateModePackageFiles()
generateACVPTest()
generateParamsFiles()
generateSourceFiles()
}
Expand Down Expand Up @@ -212,6 +213,40 @@ func generateModePackageFiles() {
}
}

// Generates modeX/dilithium.go from templates/pkg.templ.go
func generateACVPTest() {
tl, err := template.ParseFiles("templates/acvp.templ.go")
if err != nil {
panic(err)
}

for _, mode := range Modes {
if !strings.HasPrefix(mode.Name, "ML-DSA") {
continue
}

buf := new(bytes.Buffer)
err := tl.Execute(buf, mode)
if err != nil {
panic(err)
}

res, err := format.Source(buf.Bytes())
if err != nil {
panic("error formating code")
}

offset := strings.Index(string(res), TemplateWarning)
if offset == -1 {
panic("Missing template warning in pkg.templ.go")
}
err = os.WriteFile(mode.PkgPath()+"/acvp_test.go", res[offset:], 0o644)
if err != nil {
panic(err)
}
}
}

// Copies mode3 source files to other modes
func generateSourceFiles() {
files := make(map[string][]byte)
Expand Down
266 changes: 266 additions & 0 deletions sign/dilithium/templates/acvp.templ.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions sign/dilithium/templates/pkg.templ.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading