Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KNN graph handling and outlier detection in issue managers #1155

Merged
merged 14 commits into from
Jun 24, 2024
Merged

Refactor KNN graph handling and outlier detection in issue managers #1155

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b87e44c
feat: Refactor knn setup code in near-duplicate issue manager
elisno Jun 19, 2024
4960555
rename imported functions being tested from knn_graph_helpers
elisno Jun 19, 2024
1c2ba70
Refactor KNN graph setup in Non-IID Issue Manager
elisno Jun 20, 2024
31d1053
Refactor KNN graph setup in unferperforming group issue manager
elisno Jun 20, 2024
6b202fc
Refactor KNN graph setup in data valuation issue manager
elisno Jun 20, 2024
190e903
Merge branch 'master' into refactor-knn-graph-recomputation
elisno Jun 20, 2024
fb775e3
address mypy and flake8 issues
elisno Jun 20, 2024
8762259
Refactor OutlierIssueManager for improved flexibility and consistency
elisno Jun 21, 2024
7b1a3f9
feat: Add xfail reason to test_default_issue_types
elisno Jun 21, 2024
5f82ab4
rename variables in _process_knn_graph_from_inputs for clarity
elisno Jun 24, 2024
3f487f1
remove unused needs_recompute variable for provided knn_graph
elisno Jun 24, 2024
38cf94f
_check_pred_probs method in NonIIDIssueManager renamed to _determine_…
elisno Jun 24, 2024
3cd60a5
improve error handling for insufficient knn graph in OutlierIssueManager
elisno Jun 24, 2024
6ccfc76
Remove unused _score_with_features method from OutlierIssueManager
elisno Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused needs_recompute variable for provided knn_graph
  • Loading branch information
@elisno
elisno committed Jun 24, 2024
commit 3f487f12405a942f3468ce09a65350113661fe5b
1 change: 0 additions & 1 deletion cleanlab/datalab/internal/issue_manager/knn_graph_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def _process_knn_graph_from_inputs(
knn_graph: Optional[csr_matrix] = None
if provided_knn_graph is not None:
knn_graph = provided_knn_graph
needs_recompute = False
elif existing_knn_graph is not None:
knn_graph = existing_knn_graph
num_neighbors = num_neighbors_in_knn_graph(knn_graph) if knn_graph is not None else -1
Expand Down