Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a knn module #1117

Merged
merged 60 commits into from
May 14, 2024
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
b9b9274
Add test for all identical examples in test_regression.py
elisno May 3, 2024
182f50c
Add tests for detecting label issues in all identical examples dataset
elisno May 3, 2024
a0c197c
Add tests for detecting label issues in all identical examples dataset
elisno May 3, 2024
fb93c07
clarify test_all_identical_examples in test_regression.py
elisno May 3, 2024
08e86a6
remove unused Datalab test fixtures in test_all_identical_examples.py
elisno May 3, 2024
ec8743e
Improve readability and documentation of test class for all identical…
elisno May 3, 2024
cbd1eab
Rename variable for number of feature columns (K -> M)
elisno May 3, 2024
e841249
add more issue types for classification (underperforming groups and c…
elisno May 4, 2024
49b17ee
fix typos
elisno May 4, 2024
25c4c83
update documentation of TestAllIdenticalExamplesDataset
elisno May 4, 2024
747331a
Add decide_metric function to determine distance metric for neighbor …
elisno May 2, 2024
e6f2251
Add NeighborSearch protocol for k-nearest neighbors search
elisno May 2, 2024
f90641e
Add types for FeatureArray and Metric in neighbor/types.py
elisno May 2, 2024
eae62e8
rename test file
elisno May 2, 2024
a40f31d
Add features_to_knn function to build and fit a k-nearest neighbors s…
elisno May 2, 2024
a588774
export features_to_knn from neighbor submodule
elisno May 2, 2024
0604ab3
Add docs for cleanlab.internal.neighbor modules
elisno May 2, 2024
a0d6579
correct neighbor.py
elisno May 2, 2024
638ae31
let search.py only work with NearestNeighbors
elisno May 2, 2024
a13c1f8
refactor outlier.py to use knn construction function
elisno May 2, 2024
76d16d2
Refactor duplicate.py to use features_to_knn function for constructin…
elisno May 3, 2024
5b33870
Refactor duplicate.py to use the knn_to_knn_graph function defined in…
elisno May 3, 2024
45c4c3f
remove unused imports in outlier.py
elisno May 3, 2024
32d80ff
test knn_to_knn_graph
elisno May 3, 2024
a44d367
ignore unused import in __init__.py
elisno May 3, 2024
ceb3744
Refactor regression.rank.py to use features_to_knn function for const…
elisno May 3, 2024
1082702
Fix default value for neighbor_metric in rank.py
elisno May 3, 2024
8d662e2
improve clarity of code selecting number of neighbors, add comments
elisno May 6, 2024
4395874
Refactor metric.py to improve clarity of code selecting number of nei…
elisno May 6, 2024
e2dd0fc
rename knn_to_knn_graph to construct_knn_graph_from_index
elisno May 6, 2024
47a7715
add edge case for test_features_to_knn where last 11 points are ident…
elisno May 6, 2024
85b7704
Test more attributes of NearestNeighbors object
elisno May 6, 2024
c69205c
comment on DEFAULT_K
elisno May 6, 2024
c826901
Appy suggestion
elisno May 6, 2024
04ef982
Move type alias definitions to cleanlab/typing.py
elisno May 6, 2024
019629b
add comment about distance_metric being logged as string
elisno May 6, 2024
b21db8f
fix imports of types
elisno May 6, 2024
3eb4d1b
delete types.py, all types moved to typing.py
elisno May 6, 2024
f45370d
enumerate properties and attributes that a NearestNeighbors-like obje…
elisno May 6, 2024
dd331c6
Split decide_metric into two functions
elisno May 6, 2024
304ef71
ensure euclidean metric is used for outre method of computing label q…
elisno May 6, 2024
e392b73
rename module neighbor.py to knn_graph.py
elisno May 6, 2024
981776f
fix import of renamed function for deciding on default metric
elisno May 6, 2024
694625b
Replace .kneighbors_graph calls with construct_knn_graph_from_index c…
elisno May 6, 2024
b4f7a1e
Add construct_knn_graph_from_features to let issue managers create kn…
elisno May 6, 2024
fb52a6b
add more test cases for all-identical examples.
elisno May 6, 2024
31f9350
Refactor NearDuplicateIssueManager to use construct_knn_graph_from_fe…
elisno May 6, 2024
acefd1d
update docs
elisno May 6, 2024
cf798b0
update comment
elisno May 6, 2024
b420a5a
Merge branch 'master' into knn-module
elisno May 6, 2024
579bdb0
remove unused imports
elisno May 6, 2024
3314ea3
Update cleanlab/internal/neighbor/knn_graph.py
elisno May 7, 2024
402d3fe
Update cleanlab/internal/neighbor/knn_graph.py
elisno May 7, 2024
d100541
Update construct_knn_graph_from_features to return both knn_graph and…
elisno May 7, 2024
c6ec459
improve code readability in _configure_num_neighbors
elisno May 7, 2024
318d9a5
Rename function for accuracy
elisno May 7, 2024
c8a7061
remove unused import
elisno May 7, 2024
22965b9
Apply suggestions from code review
elisno May 13, 2024
d4d2d3a
Update cleanlab/internal/neighbor/metric.py
elisno May 14, 2024
bda30f2
apply black formatter
elisno May 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delete types.py, all types moved to typing.py
  • Loading branch information
elisno committed May 6, 2024
commit 3eb4d1b005eea0f5da216a18dbb6c9de4d59fdbf
elisno marked this conversation as resolved.
Outdated
Show resolved Hide resolved
Empty file.