Skip to content

Commit

Permalink
fix PythonBinaryDescriptionTest
Browse files Browse the repository at this point in the history
Summary: using platform-specific paths in tests

Test Plan: ci, locally

Reviewed By: Coneko

fbshipit-source-id: 2aa2e3e
  • Loading branch information
ilya-klyuchnikov authored and Facebook Github Bot 2 committed Jun 7, 2016
1 parent fb95046 commit 52e6e0f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import static org.junit.Assert.assertThat;

import com.facebook.buck.io.MorePaths;
import com.facebook.buck.rules.DefaultTargetNodeToBuildRuleTransformer;
import com.facebook.buck.cli.FakeBuckConfig;
import com.facebook.buck.cxx.CxxBinaryBuilder;
Expand Down Expand Up @@ -514,7 +515,7 @@ public NativeLinkStrategy getNativeLinkStrategy() {
Iterables.transform(
binary.getComponents().getModules().keySet(),
Functions.toStringFunction()),
Matchers.containsInAnyOrder("hello/extension.so"));
Matchers.containsInAnyOrder(MorePaths.pathWithPlatformSeparators("hello/extension.so")));
}

@Test
Expand Down
1 change: 0 additions & 1 deletion windows_failures.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
!com.facebook.buck.dotnet.CSharpLibraryIntegrationTest#shouldCompileLibraryWithAPrebuiltDependency
!com.facebook.buck.dotnet.CSharpLibraryIntegrationTest#shouldCompileLibraryWithSystemProvidedDeps
!com.facebook.buck.python.PrebuiltPythonLibraryIntegrationTest
!com.facebook.buck.python.PythonBinaryDescriptionTest#extensionDepUsingMergedNativeLinkStrategy
!com.facebook.buck.python.PythonBinaryIntegrationTest
!com.facebook.buck.python.PythonSrcZipIntegrationTest
!com.facebook.buck.python.PythonTestIntegrationTest
Expand Down

0 comments on commit 52e6e0f

Please sign in to comment.