Integration azure event hub #262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolasvion
commented
Mar 19, 2021
nicolasvion
commented
- Fixes based on a basic customer's case
- Microsoft.EventHub/clusters => Microsoft.EventHub/namespaces
- Default warning values at 5% (0 seems not relevant)
nicolasvion
requested review from
BzSpi,
cvauvarin,
Shr3ps and
xp-1000
as code owners
nicolasvion
force-pushed
the
integration_azure-event-hub
branch
3 times, most recently
from
18345c4 to
38312f0
Compare
nicolasvion
force-pushed
the
integration_azure-event-hub
branch
from
dafe652 to
33b7d42
Compare
|
Can you split this in 2 PRs? maybe one for the real fixes on namespace, another for the temporary one for the tags bug. |
xp-1000
added
detectors
|
without answer from the author I convert his PR to draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.