Skip to content

Classic editor's voice label is semantically incorrectΒ #15352

Open
@oleq

Description

πŸ“ Provide a description of the improvement

The classic editor's voice label is implemented incorrectly (<label id="foo"> + <div class="ck-editor" aria-labelledby="foo">). For instance, the label is missing the for attribute. And even if it had it, this would still be incorrect.

On top of it:

  • <label for="foo"> + <div class="ck-editor" id="foo"> combo, besides also being semantically incorrect, does not get recognized by screen readers when the label is hidden anyway (NVDA)
    • there's no place we can display it in the classic editor's UI.
  • having the for attribute would mean we would need to assign ids to editors, which is a complex topic.

Possible solutions

  • Use aria-label (needs to be checked),
  • Rename label to span <label id="foo"> + <div class="ck-editor" aria-labelledby="foo"> -> <span id="foo"> + <div class="ck-editor" aria-labelledby="foo">

If you'd like to see this improvement implemented, add a πŸ‘ reaction to this post.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    domain:accessibilityThis issue reports an accessibility problem.package:editor-classicsupport:2An issue reported by a commercially licensed client.type:improvementThis issue reports a possible enhancement of an existing feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions