Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose toggle buttons in accessibility tree #5123

Merged
merged 26 commits into from
Apr 9, 2022
Merged

Expose toggle buttons in accessibility tree #5123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c8f10c1
Add manual test.
Comandeer Mar 12, 2022
8ff5fd5
Add uni tests.
Comandeer Mar 12, 2022
6d0492f
Add `isToggle` option.
Comandeer Mar 12, 2022
3ab065a
Add ultimate manual test.
Comandeer Mar 12, 2022
f1e2386
Move button test helpers to separate file.
Comandeer Mar 12, 2022
65092e3
Refactor tests for `[aria-pressed]`.
Comandeer Mar 12, 2022
771d372
Implement toggle buttons in `basicstyles` plugin.
Comandeer Mar 12, 2022
8a9385f
Implement toggle buttons in `bidi` plugin.
Comandeer Mar 12, 2022
1d21e12
Implement toggle buttons in `blockquote` plugin.
Comandeer Mar 12, 2022
44ad6ad
Implement toggle buttons in `copyformatting` plugin.
Comandeer Mar 12, 2022
c5d90c4
Implement toggle buttons in `justify` plugin.
Comandeer Mar 12, 2022
a113b61
Implement toggle buttons in `list` plugin.
Comandeer Mar 12, 2022
d7bd8c0
Implement toggle buttons in `sourcearea` plugin.
Comandeer Mar 12, 2022
965184a
Add manual test for screen reader.
Comandeer Mar 12, 2022
24b9d51
Small improvements to the manual test.
Comandeer Mar 12, 2022
6239f00
Make Maximize button use `[aria-pressed]` attribute instead of dynami…
Comandeer Mar 15, 2022
7972fbc
Remove toggle template.
Comandeer Mar 23, 2022
0e2417c
Update manual test description.
Comandeer Mar 25, 2022
0125f46
Codestyle fixes for button helpers.
Comandeer Mar 25, 2022
76403c6
Fix typo in the manual test.
Comandeer Mar 30, 2022
4d46118
Rename variables.
Comandeer Mar 30, 2022
cefd314
Rephrase comment.
Comandeer Mar 30, 2022
3681428
Add manual test for menubutton.
Comandeer Mar 30, 2022
509d2cc
Add changelog entry
sculpt0r Mar 31, 2022
e576d50
Improved changelog message, moved changelog entries to a major release.
jacekbogdanski Apr 9, 2022
dc0e60c
Updated version tag to 4.19.0
jacekbogdanski Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement toggle buttons in bidi plugin.
  • Loading branch information
@Comandeer @sculpt0r
Comandeer authored and sculpt0r committed Mar 28, 2022
commit 8a9385f1d396fc3d9f94265640c0d60dc6641908
1 change: 1 addition & 0 deletions plugins/bidi/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@

if ( editor.ui.addButton ) {
editor.ui.addButton( buttonName, {
isToggle: true,
label: buttonLabel,
command: commandName,
toolbar: 'bidi,' + order
Expand Down
12 changes: 12 additions & 0 deletions tests/plugins/bidi/aria.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/* bender-tags: editor */
/* bender-ckeditor-plugins: toolbar,bidi*/
/* bender-include: ../button/_helpers/buttontools.js */
/* global buttonTools */

bender.editor = true;

// (#2444)
bender.test( buttonTools.createAriaPressedTests( 'test_editor', [
'BidiLtr',
'BidiRtl'
] ) );