Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.14 Backports 2024-12-01 #36284

Merged

Conversation

nbusseneau
Copy link
Member

@nbusseneau nbusseneau commented Dec 1, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 36089

[ upstream commit a7e9f0e ]

Currently, the etcd client is initialized with a context that gets
immediately closed once the initialization completed, in turn causing
the etcd client to be stopped. Let's fix this by using the parent
context, which gets closed only once the migration terminates.

Additionally, let's explicitly wait for the client to connect, so
that we can return an explicit error in case of problems, rather
than failing at a later stage.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 7d1a25a ]

The retrieval of node information is not required during the migration
of identities, and the current implementation leads to a panic given
that the local node store is not initialized. Hence, let's just drop
it altogether.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
[ upstream commit 20ef157 ]

shutdowner.Shutdown takes a variadic number of parameters, hence let's
just omit it.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added kind/backports This PR provides functionality previously merged into master. backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. labels Dec 1, 2024
@nbusseneau nbusseneau marked this pull request as ready for review December 1, 2024 15:35
@nbusseneau nbusseneau requested a review from a team as a code owner December 1, 2024 15:35
@nbusseneau
Copy link
Member Author

/test-backport-1.14

@nbusseneau nbusseneau requested a review from giorio94 December 1, 2024 18:21
@julianwiedmann julianwiedmann mentioned this pull request Dec 2, 2024
1 task
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 2, 2024
@julianwiedmann julianwiedmann merged commit b18c0ff into cilium:v1.14 Dec 2, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants