Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implication of increasing Symbol name size to 16 bytes #25

Open
ang-st opened this issue Dec 13, 2021 · 1 comment
Open

Implication of increasing Symbol name size to 16 bytes #25

ang-st opened this issue Dec 13, 2021 · 1 comment

Comments

@ang-st
Copy link

ang-st commented Dec 13, 2021

Hi @chronoxor,

While we wanted to add a market pair with 10 letters, we recently noticed that Symbol name is defined as 8 bytes.

CppTrader/include/trader/matching/symbol.h

Line 26 in 5126be4

char Name[8];

What we thought could be an easy fix (just make char Name[16]) seems to have implication as there are some places where code is optimized with unrolling and bit manipulations.

Before we patch it (and eventually propose it upstream) we wanted to clarify if that kind of change could impact code mechanical sympathy and as we are not high performance cpp expert by any means, wanted you opinion on the matters

Regards
@chronoxor
Copy link
Owner

I see no problem with it. You'll see no difference until you measure nanoseconds :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ang-st @chronoxor