Clean up/refactor git configuration #7538
Open
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satmandu
requested changes
Oct 24, 2022
uberhacker
reviewed
Oct 24, 2022
| system 'git init' | ||
| system 'git config advice.detachedHead false' | ||
| system 'git config init.defaultBranch master' | ||
| system 'git init --quiet', exception: true # use --quiet to suppress default branch name warning |
There was a problem hiding this comment.
I'm not a fan of quiet. Hiding stuff is not what I prefer.
There was a problem hiding this comment.
There is no other way to hide this:
Performing pre-flight checks...
No precompiled binary available for your platform, downloading source...
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: git branch -m <name>
There was a problem hiding this comment.
Have you tried git config --global init.defaultBranch master? That should make the message go away.
There was a problem hiding this comment.
We should probably start setting git config --global init.defaultBranch main since that's becoming the new norm...
There was a problem hiding this comment.
Can we get rid of line 775 and merge this?
The git config line in line 776 should in theory make this message go away, no?
uberhacker
reviewed
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small little refactor for our git clone code.
Changes:
--quiettogit initto suppress the new warning about branch namesAdditional information
Works properly:
x86_64i686armv7lRun the following to get this pull request's changes locally for testing.