From 815a0146fe33b346c520e05d2e308370e2b272fc Mon Sep 17 00:00:00 2001 From: mloning Date: Thu, 1 Oct 2020 12:24:32 +0100 Subject: [PATCH] Update PR template --- .github/PULL_REQUEST_TEMPLATE.md | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2346d996b96..413fe4824c6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,5 @@ #### Reference Issues/PRs @@ -14,26 +14,30 @@ is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests #### What does this implement/fix? Explain your changes. -#### Does your contribution introduce a new dependency? If yes, which one? +#### Does your contribution introduce a new dependency? If yes, which one? -#### PR checklist for new estimators +#### PR checklist -- [ ] I've added unit tests and made sure they pass locally. -- [ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works. -- [ ] I've updated sktime's [CODEOWNERS](https://github.com/alan-turing-institute/sktime/blob/master/CODEOWNERS) and I'm committed to maintain my algorithm. -- [ ] I've added myself to the list of contributors. +##### For all contributions +- [ ] I've added myself to the [list of contributors](https://github.com/alan-turing-institute/sktime/blob/master/.all-contributorsrc). +- [ ] Optionally, I've updated sktime's [CODEOWNERS](https://github.com/alan-turing-institute/sktime/blob/master/CODEOWNERS) to receive notifications about future changes to these files. +- [ ] I've added unit tests and made sure they pass locally. + +##### For new estimators - [ ] I've added the estimator to the online documentation. ---> +- [ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works. + #### Any other comments?