Skip to content

Commit

Permalink
Update PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
mloning committed Oct 1, 2020
1 parent 79a756b commit 815a014
Showing 1 changed file with 15 additions and 11 deletions.
26 changes: 15 additions & 11 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/alan-turing-institute/sktime/blob/master/CONTRIBUTING.md
Thanks for contributing a pull request! Please ensure you have taken a look at our contribution guide: https://github.com/alan-turing-institute/sktime/blob/master/CONTRIBUTING.md
-->

#### Reference Issues/PRs
Expand All @@ -14,26 +14,30 @@ is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests

#### What does this implement/fix? Explain your changes.
<!--
A clear and concise description of what you have implemented.
A clear and concise description of what you have implemented.
-->

#### Does your contribution introduce a new dependency? If yes, which one?
#### Does your contribution introduce a new dependency? If yes, which one?

<!--
If your contribution does add a new hard dependency, we may suggest to initially develop your contribution in a separate companion package in https://github.com/sktime/ to keep external dependencies of the core sktime package to a minimum.
If your contribution does add a new hard dependency, we may suggest to initially develop your contribution in a separate companion package in https://github.com/sktime/ to keep external dependencies of the core sktime package to a minimum.
-->


#### PR checklist for new estimators
#### PR checklist
<!--
This is only relevant if you contribute a new estimator (classifiers, regressors, forecasters, etc.). If so, please go through the checklist below. Otherwise please ignore the check list.
Please go through the checklist below. Please feel free to remove points if they are not applicable.
-->

- [ ] I've added unit tests and made sure they pass locally.
- [ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.
- [ ] I've updated sktime's [CODEOWNERS](https://github.com/alan-turing-institute/sktime/blob/master/CODEOWNERS) and I'm committed to maintain my algorithm.
- [ ] I've added myself to the list of contributors.
##### For all contributions
- [ ] I've added myself to the [list of contributors](https://github.com/alan-turing-institute/sktime/blob/master/.all-contributorsrc).
- [ ] Optionally, I've updated sktime's [CODEOWNERS](https://github.com/alan-turing-institute/sktime/blob/master/CODEOWNERS) to receive notifications about future changes to these files.
- [ ] I've added unit tests and made sure they pass locally.

##### For new estimators
- [ ] I've added the estimator to the online documentation.
-->
- [ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.


#### Any other comments?
<!--
Expand Down

0 comments on commit 815a014

Please sign in to comment.