chore: callback controller specs

chatwoot · sojan-official · Jan 16, 2023 · Dec 30, 2022 · Dec 30, 2022 · Jan 3, 2023
commit 908c40912779a02fd19de66a4c3cfea62a9a8d39
diff --git a/app/controllers/microsoft/callbacks_controller.rb b/app/controllers/microsoft/callbacks_controller.rb
@@ -7,14 +7,12 @@ def show
       redirect_uri: "#{base_url}/microsoft/callback"
     )
 
-    ActiveRecord::Base.transaction do
-      inbox = find_or_create_inbox
-      ::Redis::Alfred.delete(users_data['email'])
-      redirect_to app_microsoft_inbox_agents_url(account_id: account.id, inbox_id: inbox.id)
-    rescue StandardError => e
-      Rails.logger.error e
-      redirect_to microsoft_app_redirect_url
-    end
+    inbox = find_or_create_inbox
+    ::Redis::Alfred.delete(users_data['email'])
+    redirect_to app_microsoft_inbox_agents_url(account_id: account.id, inbox_id: inbox.id)
+  rescue StandardError => e
+    ChatwootExceptionTracker.new(e).capture_exception
+    redirect_to '/'
   end
 
   private
@@ -40,24 +38,26 @@ def account
     @account ||= Account.find(account_id)
   end
 
-  def microsoft_app_redirect_url
-    app_new_microsoft_inbox_url(account_id: account.id)
-  end
-
   def find_or_create_inbox
-    channel_email = create_imap_email_channel
-
-    return channel_email.inbox if channel_email.inbox.presence
+    channel_email = Channel::Email.find_by(email: users_data['email'], account: account)
+    channel_email ||= create_microsoft_channel_with_inbox
+    update_microsoft_channel(channel_email)
+    channel_email.inbox
+  end
 
-    account.inboxes.create_or_find_by!(
-      account: account,
-      channel: channel_email,
-      name: users_data['name']
-    )
+  def create_microsoft_channel_with_inbox
+    ActiveRecord::Base.transaction do
+      channel_email = Channel::Email.create!(email: users_data['email'], account: account)
+      account.inboxes.create!(
+        account: account,
+        channel: channel_email,
+        name: users_data['name']
+      )
+      channel_email
+    end
   end
 
-  def create_imap_email_channel
-    channel_email = Channel::Email.find_or_create_by!(email: users_data['email'], account: account)
+  def update_microsoft_channel(channel_email)
     channel_email.update!({
                             imap_login: users_data['email'], imap_address: 'outlook.office365.com',
                             imap_port: '993', imap_enabled: true,
@@ -68,6 +68,5 @@ def create_imap_email_channel
                               expires_on: (Time.current.utc + 1.hour).to_s
                             }
                           })
-    channel_email.reload
   end
 end
diff --git a/spec/controllers/microsoft/callbacks_controller_spec.rb b/spec/controllers/microsoft/callbacks_controller_spec.rb
@@ -2,42 +2,66 @@
 
 RSpec.describe 'Microsoft::CallbacksController', type: :request do
   let(:account) { create(:account) }
-  let(:administrator) { create(:user, account: account, role: :administrator) }
-  let(:microsoft_client) do
-    OAuth2::Client.new('client_id', 'client_secret', {
-                         site: 'https://login.microsoftonline.com',
-                         redirect_uri: 'http://0.0.0.0/microsoft/callback',
-                         authorize_url: 'https://login.microsoftonline.com/common/oauth2/v2.0/authorize'
-                       })
-  end
-  let(:auth_code) { microsoft_client.auth_code }
+  let(:code) { SecureRandom.hex(10) }
+  let(:email) { Faker::Internet.email }
 
   before do
-    Redis::Alfred.set('test@test.com', account.id)
-    OAuth2::Response.register_parser(:id_token, ['application/json']) do |_body|
-      { id_token: JWT.encode({ email: 'test@test.com', name: 'test' }, false) }
-    end
+    Redis::Alfred.set(email, account.id)
   end
 
   describe 'GET /microsoft/callback' do
+    let(:response_body_success) do
+      { id_token: JWT.encode({ email: email, name: 'test' }, false), access_token: SecureRandom.hex(10), token_type: 'Bearer',
+        refresh_token: SecureRandom.hex(10) }
+    end
+
     it 'creates inboxes if authentication is successful' do
-      headers = { 'Content-Type' => 'application/json' }
-      body = { id_token: JWT.encode({ email: 'test@test.com', name: 'test' }, false) }
-      # rubocop:disable RSpec/VerifiedDoubles
-      microsoft_response = double('response', headers: headers, body: body)
-      subject = OAuth2::Response.new(microsoft_response)
-      response = double(OAuth2::Response, response: subject)
-      # rubocop:enable RSpec/VerifiedDoubles
-      allow(OAuth2::Client).to receive(:new).and_return(microsoft_client)
-      allow(microsoft_client).to receive(:auth_code).and_return(auth_code)
-      allow(auth_code).to receive(:get_token).and_return(response)
-
-      get microsoft_callback_url
-
-      account.reload
+      stub_request(:post, 'https://login.microsoftonline.com/common/oauth2/v2.0/token')
+        .with(body: { 'code' => code, 'grant_type' => 'authorization_code',
+                      'redirect_uri' => "#{ENV.fetch('FRONTEND_URL', nil)}/microsoft/callback" })
+        .to_return(status: 200, body: response_body_success.to_json, headers: { 'Content-Type' => 'application/json' })
+
+      get microsoft_callback_url, params: { code: code }
+
       expect(response).to redirect_to app_microsoft_inbox_agents_url(account_id: account.id, inbox_id: account.inboxes.last.id)
       expect(account.inboxes.count).to be 1
-      expect(account.inboxes.last.name).to eq 'test'
+      inbox = account.inboxes.last
+      expect(inbox.name).to eq 'test'
+      expect(inbox.channel.reload.provider_config.keys).to include('access_token', 'refresh_token', 'expires_on')
+      expect(inbox.channel.reload.provider_config['access_token']).to eq response_body_success[:access_token]
+      expect(inbox.channel.imap_address).to eq 'outlook.office365.com'
+      expect(Redis::Alfred.get(email)).to be_nil
+    end
+
+    it 'creates updates inbox channel config if inbox exists and authentication is successful' do
+      inbox = create(:channel_email, account: account, email: email)&.inbox
+      expect(inbox.channel.provider_config).to eq({})
+
+      stub_request(:post, 'https://login.microsoftonline.com/common/oauth2/v2.0/token')
+        .with(body: { 'code' => code, 'grant_type' => 'authorization_code',
+                      'redirect_uri' => "#{ENV.fetch('FRONTEND_URL', nil)}/microsoft/callback" })
+        .to_return(status: 200, body: response_body_success.to_json, headers: { 'Content-Type' => 'application/json' })
+
+      get microsoft_callback_url, params: { code: code }
+
+      expect(response).to redirect_to app_microsoft_inbox_agents_url(account_id: account.id, inbox_id: account.inboxes.last.id)
+      expect(account.inboxes.count).to be 1
+      expect(inbox.channel.reload.provider_config.keys).to include('access_token', 'refresh_token', 'expires_on')
+      expect(inbox.channel.reload.provider_config['access_token']).to eq response_body_success[:access_token]
+      expect(inbox.channel.imap_address).to eq 'outlook.office365.com'
+      expect(Redis::Alfred.get(email)).to be_nil
+    end
+
+    it 'redirects to microsoft app in case of error' do
+      stub_request(:post, 'https://login.microsoftonline.com/common/oauth2/v2.0/token')
+        .with(body: { 'code' => code, 'grant_type' => 'authorization_code',
+                      'redirect_uri' => "#{ENV.fetch('FRONTEND_URL', nil)}/microsoft/callback" })
+        .to_return(status: 401)
+
+      get microsoft_callback_url, params: { code: code }
+
+      expect(response).to redirect_to '/'
+      expect(Redis::Alfred.get(email).to_i).to eq account.id
     end
   end
 end