Spec for hook execution services

chatwoot · pranavrajs · Jan 9, 2020 · Nov 30, 2019 · Nov 30, 2019 · Dec 1, 2019
commit d326f7e5953a74f58c94a8faaa76897bca757ab1
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -4,13 +4,13 @@ require:
   - rubocop-rspec
 inherit_from: .rubocop_todo.yml
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 150
 Metrics/ClassLength:
   Max: 125
 RSpec/ExampleLength:
   Max: 15
-Documentation:
+Style/Documentation:
   Enabled: false
 Style/FrozenStringLiteralComment:
   Enabled: false

diff --git a/app/controllers/widgets_controller.rb b/app/controllers/widgets_controller.rb
@@ -4,12 +4,14 @@ class WidgetsController < ActionController::Base
   before_action :set_contact
   before_action :build_contact
 
-  private
+  def index
+    render
+  end
 
-  def set_contact
-    return if @auth_token_params[:contact_id].nil?
+  private
 
-    @contact = @web_widget.inbox.contacts.find(@auth_token_params[:contact_id])
+  def set_web_widget
+    @web_widget = ::Channel::WebWidget.find_by!(website_token: permitted_params[:website_token])
   end
 
   def set_token
@@ -21,8 +23,10 @@ def set_token
                          end
   end
 
-  def set_web_widget
-    @web_widget = ::Channel::WebWidget.find_by!(website_token: permitted_params[:website_token])
+  def set_contact
+    return if @auth_token_params[:contact_id].nil?
+
+    @contact = @web_widget.inbox.contacts.find(@auth_token_params[:contact_id])
   end
 
   def build_contact
@@ -38,8 +42,4 @@ def build_contact
   def permitted_params
     params.permit(:website_token, :cw_conversation)
   end
-
-  def secret_key
-    Rails.application.secrets.secret_key_base
-  end
 end
diff --git a/spec/controllers/widgets_controller_spec.rb b/spec/controllers/widgets_controller_spec.rb
@@ -9,8 +9,9 @@
       expect(response).to be_successful
     end
 
-    it 'raises when called with website_token' do
-      expect { get widget_url }.to raise_exception ActiveRecord::RecordNotFound
+    it 'returns 404 when called with out website_token' do
+      get widget_url
+      expect(response.status).to eq(404)
     end
   end
 end
diff --git a/spec/factories/messages.rb b/spec/factories/messages.rb
@@ -7,9 +7,12 @@
     message_type { 'incoming' }
     content_type { 'text' }
     fb_id { SecureRandom.uuid }
-    account
-    inbox
-    conversation
-    user { build(:user) }
+    account { create(:account) }
+
+    after(:build) do |message|
+      message.user ||= create(:user, account: message.account)
+      message.conversation ||= create(:conversation, account: message.account)
+      message.inbox ||= create(:inbox, account: message.account)
+    end
   end
 end
diff --git a/spec/models/message_spec.rb b/spec/models/message_spec.rb
@@ -8,4 +8,19 @@
     it { is_expected.to validate_presence_of(:conversation_id) }
     it { is_expected.to validate_presence_of(:account_id) }
   end
+
+  context 'when message is created' do
+    let(:message) { build(:message) }
+
+    it 'triggers ::MessageTemplates::HookExecutionService' do
+      hook_execution_service = double
+      allow(::MessageTemplates::HookExecutionService).to receive(:new).and_return(hook_execution_service)
+      allow(hook_execution_service).to receive(:perform).and_return(true)
+
+      message.save!
+
+      expect(::MessageTemplates::HookExecutionService).to have_received(:new).with(message: message)
+      expect(hook_execution_service).to have_received(:perform)
+    end
+  end
 end
diff --git a/spec/services/message_templates/hook_execution_service_spec.rb b/spec/services/message_templates/hook_execution_service_spec.rb
@@ -0,0 +1,20 @@
+require 'rails_helper'
+
+describe ::MessageTemplates::HookExecutionService do
+  context 'when it is a first message from web widget' do
+    it 'calls ::MessageTemplates::Template::EmailCollect' do
+      message = create(:message)
+      # this hook will only get executed for conversations with out any template messages
+      message.conversation.messages.template.destroy_all
+
+      email_collect_service = double
+      allow(::MessageTemplates::Template::EmailCollect).to receive(:new).and_return(email_collect_service)
+      allow(email_collect_service).to receive(:perform).and_return(true)
+
+      described_class.new(message: message).perform
+
+      expect(::MessageTemplates::Template::EmailCollect).to have_received(:new).with(conversation: message.conversation)
+      expect(email_collect_service).to have_received(:perform)
+    end
+  end
+end
diff --git a/spec/services/message_templates/template/email_collect_spec.rb b/spec/services/message_templates/template/email_collect_spec.rb
@@ -0,0 +1,12 @@
+require 'rails_helper'
+
+describe ::MessageTemplates::Template::EmailCollect do
+  context 'when this hook is called' do
+    let(:conversation) { create(:conversation) }
+
+    it 'creates the email collect messages' do
+      described_class.new(conversation: conversation).perform
+      expect(conversation.messages.count).to eq(3)
+    end
+  end
+end