Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag and drop subtitles in the flatpak version. #775

Open
mkblast opened this issue May 12, 2022 · 12 comments
Open

Can't drag and drop subtitles in the flatpak version. #775

mkblast opened this issue May 12, 2022 · 12 comments
Labels

Comments

@mkblast
Copy link

mkblast commented May 12, 2022

Overview Description:
when you use the flatpak version and you want to attach a subtitle and you drag it to the player from the file manager (GNOME files), the file wont load, the only way to load a subtitle it to use the file picker.
Steps to Reproduce:

  1. Try to load a subtitle by draging it from the file manager.

Actual Results:
The subtitle wont load.

Expected Results:
Load normally

Version:
0.23

Additional Information:
IDK but im using Fedora 36 under wayland.

@gnome-mpv
Copy link
Collaborator

This should start working once Files is ported to GTK4.

@brainchild0
Copy link

brainchild0 commented Oct 7, 2022

Same issue, running on Cinnamon, in Linux Mint 21, with Nemo (v5.4.3) as file manager and Celluloid 0.21 installed through APT package from Mint distribution (i.e. not Flatpak).

@mkblast
Copy link
Author

mkblast commented Nov 15, 2022

This should start working once Files is ported to GTK4.

After updating to Fedora 37 with Files in GTK4 I still have this issue
Screencast from 2022-11-15 19-57-13.webm

@mkblast mkblast closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
@mkblast
Copy link
Author

mkblast commented Nov 15, 2022

Sorry I miss clicked and closed the Issue.

@gnome-mpv gnome-mpv reopened this Nov 16, 2022
@mkblast
Copy link
Author

mkblast commented Nov 16, 2022

Ok so I thought it could be a Flatpak problem so I went and search for other Flatpak and try if they have the same issue but I don't think so, I tested it with two apps Amberol and G4Music and they don't have the problem.

Screencast.from.2022-11-16.18-17-23.webm

And I tried with Flatpak MPV and no issue again I think this is a celluloid only bug.

Screencast.from.2022-11-16.18-23-05.webm

@brainchild0
Copy link

I am reproducing in a standard execution environment, not Flatpak, as I reported earlier.

@gnome-mpv
Copy link
Collaborator

@mkblast
Should be fixed in 8ec4892.

@brainchild0
I can't reproduce the problem with Nemo on GNOME, so the problem might be specific to Cinnamon. I'll have to set up a VM to test later. There's a small possibility that the patch above fixes your problem as well, so you may want to try it out.

@gnome-mpv
Copy link
Collaborator

@brainchild0
I just tested with a Linux Mint VM and DnD works fine for me. I tested both v0.21 and v0.24.

@brainchild0
Copy link

I haven't had a chance for a thorough test at the moment, but I am now finding that if the titles file is local, then results are as expected, but if the file is on a remote SMB/CIFS share (mounted through the GIO interface provided in the file manager), then attempts to add the titles file to a video asset already loaded fails silently.

Are you able to attempt a test case with a similar structure?

The problem loading files through drag-in-drop is not appearing for a video asset itself, only a titles sequence from a separate file.

For reference, I am currently running Nemo 5.4 and Celluloid 0.21 as provided by the LM repositories.

@gnome-mpv
Copy link
Collaborator

@brainchild0
Should be fixed with eeaabcf.

@brainchild0
Copy link

brainchild0 commented Nov 19, 2022

Great. Thanks for applying the fix. Unfortunately, it is extremely slow for any application revision to enter into the OS distribution repositories. It will likely be some time before the new functionality is reflected by my system update.

@mkblast
Copy link
Author

mkblast commented Nov 19, 2022

Should be fixed in 8ec4892.

Thanks for applying the fix, looking forward to trying it in the next update, when it rolls out and I test it ill close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants