-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnd does not work when using flatpak #300
Comments
Run |
Hello, thank you very much for quick response :) this is the output: (gnome-mpv:3): Gtk-DEBUG: Connecting to session manager |
I tried to install flatpak-libs, xdg-desktop-portal, xdg-desktop-portal-gtk- xdg-utils, gvfs-fuse, fuse, ostree-fuse, I tried to start gnome-mpv flatpak as sudo but nothing helps, I am still getting the same error :/ |
Looks like flatpak can't handle opening files via drag-and-drop yet. See: flatpak/xdg-desktop-portal#99 It should work fine if you open the file with the file chooser (press |
I already tried this but it does not work too, even opening file from command line does not work: flatpak run io.github.GnomeMpv '/data/Downloads/Curl Noise Flow.mp4' I tried to install some other flatpak applications like eog, darktble or libreoffice and they all seem working fine. They can open all files I feed to them. |
If other apps work and can open files it cant be bug of flatpak or could it? |
Enterprise Linux 7.4 is using flatpak version 0.8.7, could it be possible that opposed to newer versions it does not support some function which GnomeMpv needs for opening files? |
I think gnome-mpv's flatpak is set up such that it cannot access the host machine's filesystem directly. Instead, it relies on /cc @TingPing |
That's possible. I tested with flatpak 0.9.6, and opening files using the file chooser works fine, but command line and dnd do not. |
Ok new findings... Before I had only installed flatpak and ostree packages So when I was testing the app with additional packages (xdg-desktop-portal, fuse...) I was not testing various methods of opening file... if it it not work via command line I percieved it as non functional. I thought that it is some core bug, I had no idea that various methods of opening could work. But after you mentioned that I should try various methods of opening. I tried to install all the additional packages (xdg-desktop-portal, fuse...) and again tried to open file with plus sign icon, clicking on "open" and now it opened a "File Chooser Box"! And great thing happened, when choosing some file it started playing flawlessly! But no other type of opening a file works, double click is not working, drag and drop is not working, command line is not working. I also tested various package and for GnomeMpv only opens "File Chooser Box" only when I install xdg-desktop-portal-gtk (which pulls xdg-desktop-portal and flatpak-libs as dependencies). If I dont have it installed, clicking on "open" under plus sign icon does nothing.
(Even though Open dialog works now for me, command line, double click and drag and drop still does not work) If you need some additional information or testing please let me know Thank you for your time and have a nice day :) |
You can't just give a path to it, ideally just use
DnD is the only missing feature. I personally believe a media player is a very security sensitive application and it makes sense to limit its access. You do need a relatively new version to open paths via command line/file manager though. @hubslave You are really overthinking the whole package situation, you only need two, |
Oh and users do have an escape hatch if they don't care about security: |
TingPing thank you very much for clarification, I read more about how desktop-portal works and it makes perfect sense. But in my case xdg-desktop-portal-gtk was not installed automatically with flatpak. Maybe could it be possible for gnome-mpv to warn new users that xdg-desktop-portal-gtk is not installed (in case it is not installed?) and it is needed for proper function? "Oh and users do have an escape hatch if they don't care about security: flatpak override io.github.GnomeMpv --filesystem=host:ro" Thank you also for this tip. My question is, is it possible for media player to do any harm if it has read only access to filesystem? (I am not sure what flag --filesystem=host:ro means but I suppose it grants read only filesystem access). |
We probably could, it should be an uncommon case though.
Well if you theoretically opened malware it could upload private files. In practice you are fine, only better than traditionally unsandboxed applications.
Correct. drop the
You are on RHEL? Honestly we should just ask the package maintainer to add a dependency for that. EDIT: I poked the maintainer about it, awaiting his response. |
On Centos 7.4 but it should be the same. |
|
i added xdg-videos in flatseal, dnd works on video. but not subtitles tho |
Overview Description:
Hello, I installed GnomeMpv as flatpak from flathub repository on Enterprise Linux 7.4 minimal install with only few packages installed - Gnome Session, flatpak and ostree. Everytime I try to play any video from local disk I get this error: Playback was terminated abnormally. Reason: Loading failed.
Please could you tell me what can be the problem? Does GnomeMpv requies for proper functionallity some other packages? Should I also install packages like ostree-fuse, gvfs-fuse, ffmpeg, gstreamer...?
Steps to Reproduce:
Actual Results:
Playback was terminated abnormally. Reason: Loading failed.
Expected Results:
Video playing :)
Version:
Latest
Additional Information:
No
Thank you very much and have a nice day :)
The text was updated successfully, but these errors were encountered: