Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from GitLink to SourceLink #3036

Closed
amaitland opened this issue Feb 1, 2020 · 3 comments
Closed

Migrate from GitLink to SourceLink #3036

amaitland opened this issue Feb 1, 2020 · 3 comments
Milestone
94.3.x

Comments

@amaitland
Copy link
Member

Currently we use GitLink, it needs upgrading to a newer version so we may as well switch to SourceLink

It supports vcxproj so we can use it for our VC++ projects

https://github.com/dotnet/sourcelink/#prerequisites-for-net-projects
@amaitland amaitland mentioned this issue Feb 1, 2020
Closed
2 tasks
@amaitland
Copy link
Member Author

We can potentially look at embedding the pdb/source into the dll and not need Source link, that's another option.

dotnet/sdk#1458 (comment)

@amaitland
Copy link
Member Author

For the upcoming NETCore packages the source and pdb are built into the dll as part of #3197

I upgraded to to the latest GitLink as part of #3311

Closing this now as we'll stick with GitLink for the older packages.

Will reopen if it's deemed necessary to migrate to SourceLink in the future.

@amaitland amaitland reopened this Sep 7, 2021
@amaitland amaitland added this to the 94.0.x milestone Sep 7, 2021
@amaitland
Copy link
Member Author

Now that we build with VS2019 migrating to SourceLink is desirable as GitLink doesn't support the newer PDB format.

amaitland added a commit that referenced this issue Sep 7, 2021
@amaitland
Migrate VC++ projects from GitLink to Source link
9150638 
Forgot to migrate VC++ projects in previous commit

Resolves #3036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
94.3.x
Development

No branches or pull requests
1 participant
@amaitland