Fix corner cases related to lifecycle state of EditorComponent on events

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
cebjyre · Nov 4, 2014 · 100af7d · 100af7d
1 parent 9b70cf2
commit 100af7d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/scrollbar-component.coffee b/src/scrollbar-component.coffee
@@ -38,6 +38,9 @@ ScrollbarComponent = React.createClass
 
     @getDOMNode().addEventListener 'scroll', @onScroll
 
+  componentWillUnmount: ->
+    @getDOMNode().removeEventListener 'scroll', @onScroll
+
   shouldComponentUpdate: (newProps) ->
     return true if newProps.visible isnt @props.visible
 

diff --git a/src/text-editor-component.coffee b/src/text-editor-component.coffee
@@ -435,7 +435,8 @@ TextEditorComponent = React.createClass
       @refs.input.focus()
 
   blurred: ->
-    @setState(focused: false)
+    if @isMounted()
+      @setState(focused: false)
 
   onTextInput: (event) ->
     event.stopPropagation()

diff --git a/src/text-editor-element.coffee b/src/text-editor-element.coffee
@@ -111,7 +111,7 @@ class TextEditorElement extends HTMLElement
 
   blurred: (event) ->
     unless atom.config.get('editor.useShadowDOM')
-      if event.relatedTarget is @component?.refs.input.getDOMNode()
+      if event.relatedTarget is @component?.refs.input?.getDOMNode()
         event.stopImmediatePropagation()
         return