-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): Removing damage Penalty for the Suppressors #4490
base: main
Are you sure you want to change the base?
Conversation
Removed Damage Penalty from the makeshift suppressors and tweaked the handling of the MP5SD integral suppressor. Damage modifier for the MP5SD suppressor not changed as to reflect it's unique subsonic internal suppressor.
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feat(balance): Changing Values for the Suppressors
could we have a more descriptive PR title? from the PR title alone it's not obvious what the changes are (e.g is it a nerf? is it a buff?)
turns out handling_modifier was already inherited from suppressor. I change the loudness modifier to reflect the MP5SD's unique suppressor more accurately
…aclysm-BN into suppressor-changes
I would actually buff the MP5SD's suppressor, but I really can't tell how much is -32 loudness modifier, so I'll leave it to people who know what these values mean more. |
The easiest way is to test them out. One step is 5 sound, if I recall, so build it from there. You can debug spawn a friendly NPC and give him a mp5sd, spawn a enemy and save. Let him shoot him and then consider, how far away do you have to be to hear his firing as loud as footsteps. If it is too far in game, make the number higher than -32, for example -40. Save the value and test again until you are happy with the findings. You can easily test jsons by going to the main menu (without saving via debug) and load the save with the new values again. |
Removed Damage Penalty from the makeshift suppressors and tweaked the handling of the MP5SD integral suppressor.
The damage modifier for the MP5SD suppressor has Intentionally not changed to reflect its unique subsonic internal suppressor.
Purpose of change
Suppressors in real life don't decrease the Velocity of bullets, decreasing the damage. The normal suppressors don't have a negative damage modifier, so I removed them to make consistent.
Describe the solution
Fully removed the damage penalty from makeshift suppressor, soda bottle suppressor, and shotgun suppressor.
I've intentionally left the MP5SD's internal suppressor as it's a uniquely designed suppressor to slow the bullet to a subsonic round.
Describe alternatives you've considered
Theoretically, if the loudness values are great enough, I think as a balance mechanic it would be viable to keep the damage penalty. But from my experience, I considered the loudness modifiers as "realistic" so I wanted to tweak the modifiers as such.
I would've adjusted the suppressor's loudness modifier too to make the suppressors most realistic, but just by checking the JSON, it's hard to check how loud the are guns and what the loudness values truly mean.
Testing
Additional context
Currently, it's very unclear to me how much of what is loudness value means. if someone can/want to adjust the loudness modifiers too, feel free.
Checklist