Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): increase morale gain (and loss) from food to 12 hours #4393

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Lamandus
Copy link
Contributor

Purpose of change

First step into morale changes. This will change the timer from 2 hours until the morale completely depletes from food to 12 hours.

This also includes negative modifiers. So chugging oil is not that valid anymore and cooking high morale food is now a great boon.

Describe the solution

See above. This is not the end tho, @MrLostman is also working on morale timer buffs for other things, so this is just a first step, it may change in the future.

Describe alternatives you've considered

Testing

Additional context

Checklist

@github-actions github-actions bot added the src changes related to source code. label Mar 26, 2024
@Lamandus Lamandus requested review from chaosvolt and scarf005 March 26, 2024 15:23
@chaosvolt
Copy link
Member

Seems fine to me, just waiting to make sure no weird obscure tests will be affected by this.

@Lamandus
Copy link
Contributor Author

Seems fine to me, just waiting to make sure no weird obscure tests will be affected by this.

tests seem fine. For now

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy failure is from #4391 and thus unrelated, so this at least seems 100% fine.

@Lamandus Lamandus merged commit d6ba201 into cataclysmbnteam:main Mar 26, 2024
12 of 13 checks passed
@Lamandus Lamandus deleted the moralefood branch March 26, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants