Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corpses doesnt divide by name/kind #5869

Open
Ignaramico opened this issue Jan 3, 2025 · 1 comment
Open

corpses doesnt divide by name/kind #5869

Ignaramico opened this issue Jan 3, 2025 · 1 comment
Labels
bug easy Simple task that doesn't require understanding the code much src changes related to source code.

Comments

@Ignaramico
Copy link

Describe the bug

when you move corpses via dragging they take the name of the last picked corpse, you can separate them via advanced inventory and the show the name of the individual one, but after moving another it gets the same name as first you moved this way

Steps To Reproduce

spawn diferent mobs via debug menu
kill the mobs via debug menu
drag them
check via adavanced inventory or the examine action
see you have 5 of the same corpse

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 7601
  • Game Version: ce2c8cf [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    No Rail Stations [No_Rail_Stations],
    Prevent Zombie Revivication [no_reviving_zombies],
    Limit Fungal Growth [limit_fungal_growth],
    Item Category Overhaul [Item_Category_Overhaul],
    UDP Redux [udp_redux]
    ]

Additional context

if you stand over them and use the butcher keybinding the list shows correctly
if you separate them they still show they individual damage level correctly (pulped/burned/etc)
@Ignaramico Ignaramico added the bug label Jan 3, 2025
@scarf005
Copy link
Member

scarf005 commented Jan 3, 2025

it's probably because of item equality check not comparing names between corpses. for anyone interested, relevant code:

Cataclysm-BN/src/item.cpp

Lines 1078 to 1084 in c75fb01

if( ( corpse == nullptr && rhs.corpse != nullptr ) ||
( corpse != nullptr && rhs.corpse == nullptr ) ) {
return false;
}
if( corpse != nullptr && rhs.corpse != nullptr && corpse->id != rhs.corpse->id ) {
return false;
}

@scarf005 scarf005 added easy Simple task that doesn't require understanding the code much src changes related to source code. labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy Simple task that doesn't require understanding the code much src changes related to source code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ignaramico @scarf005