Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiation code has many problems #5856

Open
RoyalFox2140 opened this issue Dec 31, 2024 · 2 comments
Open

Radiation code has many problems #5856

RoyalFox2140 opened this issue Dec 31, 2024 · 2 comments
Labels
bug confirmed Bug that has been reproduced src changes related to source code.

Comments

@RoyalFox2140
Copy link
Collaborator

Describe the bug

There's a ton of problems with radiation.

Radiation does not decay on tiles, this means that applying radiation will apply it forever and scale forever. Tiles can permanently afflict Sieverts of radiation per hour on players.

"extra_radiation_max": 1 will apply mSv to a tile so long as the field is active, this will scale INFINITELY This creates areas more radioactive than the elephant's foot in Pripyat. I haven't tested if it can integer overflow, but it may be possible.

"extra_radiation_min": 1 NOT ONLY is it orphaned because it's not used anywhere in our game but applies 1 radiation to a player every turn, if it is used and a player stands in it for any length of time it causes massive problems. It also doesn't apply radiation to a tile, which is honestly very odd.

Steps To Reproduce

Use the field effects "extra_radiation_min" "extra_radiation_max", or alternatively observe what nuke gas does.

We have a radiation overlay in debug, check it out for testing purposes.

Screenshots

image

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Bazzite; Description: Bazzite 41 (FROM Fedora Kinoite); Release: 41; Codename: Holographic;
  • Game Version: 22673e8 [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    Alternative Map Key [alt_map_key],
    Craftable Bullet Casings [CasingCrafting],
    MST Extra [MST_Extra],
    Tankmod: Revived [Tankmod_Revived],
    No Addictions [No_Addictions],
    Limit Fungal Growth [limit_fungal_growth],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    OMT Resources [omt_resources],
    Flowing Water [flowing_water],
    No Filthy Clothing [no_filthy_clothing],
    No Wasps [No_Wasps],
    Fox's Revisions mod [FoxRevisions],
    MSX Fake Snow [UDP_BN_FAKE_SNOW],
    Item Category Overhaul [Item_Category_Overhaul],
    Prevent Zombie Revivication [no_reviving_zombies],
    Prevent Zombification [no_zombify],
    No Mutant Meat [NoMutantMeat],
    Essence 2200 BN [Essence2200_BN],
    Essence 2200 Tweaks [FoxTweaks],
    No Rail Stations [No_Rail_Stations],
    Deadlier Zombies [Deadly_Zeds],
    UDP Redux [udp_redux]
    ]

Additional context

No response

@RoyalFox2140 RoyalFox2140 added bug confirmed Bug that has been reproduced src changes related to source code. labels Dec 31, 2024
@Coolthulhu
Copy link
Member

NOT ONLY is it orphaned because it's not used anywhere in our game

We still need to maintain it for the sake of mod support, at least for now.

@RoyalFox2140
Copy link
Collaborator Author

I would like to find a use for extra_radiation_min as a minimum amount of mSv that a tile will have with a gas field on top of it, rather than giving 1 radiation per turn. This would give a lot more granular control over radiation,

extra_radiation_max Really should be the maximum allowed mSv on a tile from a gas field, so if you really wanted to have 1 Sievert of radiation you'd have to use 1000. This would stop integer overflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced src changes related to source code.
Projects
None yet
Development

No branches or pull requests

2 participants