Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No hope" mapgen json-error #5745

Open
LinKennt opened this issue Nov 20, 2024 · 6 comments
Open

"No hope" mapgen json-error #5745

LinKennt opened this issue Nov 20, 2024 · 6 comments
Labels
bug confirmed Bug that has been reproduced JSON related to game datas in JSON format. mods PR changes related to mods.

Comments

@LinKennt
Copy link

Describe the bug

Internal mod "No Hope [no_hope]" calls json-error "row X column Y: 'Z' has no terrian, furniture, or other defenition" at the "mapgen weights" Finalizing stage house_inner_garden r13/c15-16 and 18-19, r14/c13-19, r15/c14-19; and s_gas.json r19/c5.

Steps To Reproduce

  1. Create new world with "No Hope" mod
  2. Open World

Screenshots

2024-11-21.01-50-09.mp4

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.26100.1742 (24H2)
  • Game Version: aaf5b02 [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    No Rail Stations [No_Rail_Stations],
    Prevent Zombie Revivication [no_reviving_zombies],
    Limit Fungal Growth [limit_fungal_growth],
    Item Category Overhaul [Item_Category_Overhaul],
    UDP Redux [udp_redux],
    No Hope [no_hope]
    ]

Additional context

debug.log

@LinKennt LinKennt added the bug label Nov 20, 2024
@scarf005 scarf005 added the mods PR changes related to mods. label Nov 21, 2024
@blot-runner
Copy link
Contributor

blot-runner commented Nov 21, 2024

Also encountered it, to my knowledge the culprit is palettes.json in the No Hope mod. Can be fixed by adding to the mod palette the symbols used in the vanilla locations, but absent in the mod ones. Namely (all the changes are to the palettes.json of the No Hope mod):

  1. Adding the line
    "s̱": "t_region_soil",
    to the "terrain" part of the "house_w_foundation_palette" palette,

  2. Adding the line
    "nested": { "o": { "chunks": [ [ "null", 95 ], [ "house_place_air_conditioner", 5 ] ] } }
    to the same palette and

  3. Adding the line
    "M": { "item_group": "vending_medicine", "reinforced": true }
    to the "vendingmachines" part of the "road" palette

solved the problem for me. Attaching the corrected file for reference.

palettes.json

@RoyalFox2140 RoyalFox2140 added confirmed Bug that has been reproduced JSON related to game datas in JSON format. labels Nov 21, 2024
@RoyalFox2140
Copy link
Collaborator

We don't support or fix No Hope, but anyone is welcome to step up to maintain No Hope.

@blot-runner
Copy link
Contributor

We don't support or fix No Hope, but anyone is welcome to step up to maintain No Hope.

Hmm... does it mean that if I finally learn the black magic of git and choose to fix this WITHOUT becoming a full-time maintainer of the mod, the PR won't be merged?)

@chaosvolt
Copy link
Member

Nah, if you can help that'd be appreciated. It's more that right now No Hope doesn't have a dedicated maintainer. Part of the problem is the mod is an absolute rat's nest of overrides that can be a pain to sift through,especially since you then have to triage whether any given override is even nessecary in BN (a huge chunk of the mod is dedicated to re-implementing random stuff DDA has obsoleted for "muh realisms" reasons over the years, and a lot of that has at various points been re-added to BN).

@blot-runner
Copy link
Contributor

Nah, if you can help that'd be appreciated. It's more that right now No Hope doesn't have a dedicated maintainer. Part of the problem is the mod is an absolute rat's nest of overrides that can be a pain to sift through,especially since you then have to triage whether any given override is even nessecary in BN (a huge chunk of the mod is dedicated to re-implementing random stuff DDA has obsoleted for "muh realisms" reasons over the years, and a lot of that has at various points been re-added to BN).

Understood, thank you.

@RoyalFox2140
Copy link
Collaborator

We don't support or fix No Hope, but anyone is welcome to step up to maintain No Hope.

Hmm... does it mean that if I finally learn the black magic of git and choose to fix this WITHOUT becoming a full-time maintainer of the mod, the PR won't be merged?)

We'll merge anybody's work. What I meant was nobody is expected to fix No Hope so if a PR breaks No Hope we don't even know because we stopped running tests on No Hope. It is not anyone's responsibility but anyone can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

No branches or pull requests

5 participants