Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index dir option, change evaluate_passage_ranking to be consistent with CovidQA, update index to latest #33

Merged
merged 9 commits into from
May 26, 2020
Merged

Index dir option, change evaluate_passage_ranking to be consistent with CovidQA, update index to latest #33

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47fa0c6
move index dir to options and update instructions for the new index
ronakice May 25, 2020
092630f
required field
ronakice May 25, 2020
e3a17e2
change data -> indexes
ronakice May 25, 2020
847c6ac
fix bugs
ronakice May 25, 2020
d08ea67
convert to string before passing
ronakice May 25, 2020
0825de1
Consistent variable names across covidqa/marco
ronakice May 25, 2020
0251770
change to bert-base-uncased, remove do-lower-case (deprecated from tr…
ronakice May 25, 2020
18da4d1
revert to bert-base cased
ronakice May 25, 2020
81d0c93
revert to lower case
ronakice May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
required field
  • Loading branch information
@ronakice
ronakice committed May 25, 2020
commit 092630f3fb11a1a0af56ace82d44db0d055d3a85
3 changes: 1 addition & 2 deletions pygaggle/run/evaluate_kaggle_highlighter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,7 @@ def construct_bm25(_: KaggleEvaluationOptions) -> Reranker:

def main():
apb = ArgumentParserBuilder()
apb.add_opts(opt('--dataset',
type=Path),
apb.add_opts(opt('--dataset', type=Path, required=True),
opt('--index-dir', type=Path, required=True),
opt('--method',
required=True,
Expand Down