Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyserini's new prebuilt index features #10

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

qguo96
Copy link

@qguo96 qguo96 commented Sep 29, 2020

I tested with the Development Installation of pyserini.
(pyserini's current PyPI version doesn't support prebuilt index)
This modification can take advantage of pyserini's new prebuilt index features, but we need to merge this PR(castorini/pyserini#235) first. Then I can add information about lucene-index.enwiki-20180701-paragraphs.tar.gz and https://www.dropbox.com/s/6zn16mombt0wirs/lucene-index.zhwiki-20181201-paragraphs.tar.gz?dl=0 in pyserini.

@MXueguang
Copy link
Member

MXueguang commented Sep 29, 2020

@qguo96 can you update corresponding document too?
i.e. in the README.md Simple QA example, and the Chinese example, with the prebuilt index feature

@lintool
Copy link
Member

lintool commented Sep 29, 2020

@MXueguang Can you confirm that we are able to replicate the EM scores?
Let's change the documentation after Pyserini PyPI update is published.

@qguo96 Please send PR in Pyserini that adds these two indexes?

@qguo96
Copy link
Author

qguo96 commented Sep 29, 2020

@MXueguang Sure, it's better to change docs after a stable PyPI release.
@lintool get it. I will add the information in this PR (castorini/pyserini#235).

@qguo96
Copy link
Author

qguo96 commented Sep 29, 2020

I add information about enwiki and zhwiki in this PR (castorini/pyserini#235).

@amyxie361 amyxie361 merged commit 3c9c53f into castorini:development Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants