-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pay bolt12 (backends not impl) #370
Draft
thesimplekid
wants to merge
19
commits into
cashubtc:main
Choose a base branch
from
thesimplekid:bolt12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
commented
Sep 28, 2024
crates/cdk/src/mint/mod.rs
Outdated
Comment on lines
591
to
607
let offer_amount = offer.amount().ok_or(Error::InvoiceAmountUndefined)?; | ||
|
||
let (amount, currency) = match offer_amount { | ||
lightning::offers::offer::Amount::Bitcoin { amount_msats } => { | ||
(amount_msats, CurrencyUnit::Msat) | ||
} | ||
lightning::offers::offer::Amount::Currency { | ||
iso4217_code, | ||
amount, | ||
} => ( | ||
amount, | ||
CurrencyUnit::from_str(&String::from_utf8(iso4217_code.to_vec())?)?, | ||
), | ||
}; | ||
|
||
to_unit(amount, ¤cy, unit).map_err(|_err| Error::UnsupportedUnit)? | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a helper method.
thesimplekid
force-pushed
the
bolt12
branch
5 times, most recently
from
October 4, 2024 07:06
f78fd32
to
139fe9f
Compare
thesimplekid
force-pushed
the
bolt12
branch
3 times, most recently
from
October 6, 2024 16:20
1ab593c
to
e6a0b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.