fish shell support #425
Merged
fish shell support #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mightyguava
commented
Dec 23, 2024
| @@ -1,4 +1,6 @@ | |||
| #!/bin/bash | |||
| # | |||
| # THIS FILE IS GENERATED; DO NOT MODIFY | |||
There was a problem hiding this comment.
changes from running hermit init. Let me know if I should remove
alecthomas
requested changes
Dec 23, 2024
There was a problem hiding this comment.
This is awesome!
Can you also add fish to this table to add Fish support to the integration tests?
| @@ -1,4 +1,6 @@ | |||
| #!/bin/bash | |||
| # | |||
| # THIS FILE IS GENERATED; DO NOT MODIFY | |||
Actually this is going to be a bit more work than that, let's just get it in as-is. |
alecthomas
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds native support for fish shell.
Since fish isn't POSIX compliant, all scripts were translated to fish syntax (mostly by ChatGPT). There's now a new
bin/activate-hermit.fishscript that needs to be added to hermit repos to enable fish support, which hermit will add only if you runhermit initagain.I'm new to fish, so there might be some errors in the scripts. But both activate and deactivate seem to work fine in all the repos I tested in.
Closes #417.