Drop W.Coin, W.UTxO, W.TxOut usage in BalanceSpec
#4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/BalanceSpec-fewer-wallet-deps
branch
from
25dfa64 to
95fb19f
Compare
Anviking
commented
Jan 13, 2025
| lovelaceF (Coin l) | ||
| | l < 0 = "-" <> pretty (W.Coin.unsafeFromIntegral (-l)) | ||
| | otherwise = pretty (W.Coin.unsafeFromIntegral l) | ||
| lovelaceF (Coin c) = fixedF @Double 6 (fromIntegral c / 1e6) |
There was a problem hiding this comment.
From the W.Coin implementation
| address :: IsRecentEra era => TxOut era -> W.Address | ||
| address = Convert.toWallet . view addrTxOutL | ||
| address :: TxOut era -> Address | ||
| address = view addrTxOutL |
There was a problem hiding this comment.
| @@ -875,14 +871,14 @@ spec_balanceTx era = describe "balanceTx" $ do | |||
| horizon = SlotNo 20 | |||
| beyondHorizon = SlotNo 21 | |||
|
|
|||
| wallet = mkTestWallet (utxo [W.Coin 5_000_000]) | |||
| wallet = mkTestWallet (utxo [Coin 5_000_000]) | |||
There was a problem hiding this comment.
why not lovelace here?
There was a problem hiding this comment.
aha, Coin is not Value ...
abailly
merged commit 153ba89
into
anviking/ADP-3413/balanceTx-unit-conway
30 checks passed
|
@abailly for the record I was intentionally waiting with merging this until the base branch was merged 😅 |
|
My bad @Anviking ! I saw it was |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop a significant part of the usage of
W.Coin,W.TxOut,W.UTxOinBalanceSpec, as partof the effort to eventually consistently only use ledger types.
Depends on #4762