Updated version

capricciobob · Aug 12, 2020 · 0fd811a · 0fd811a
1 parent 99a770b
commit 0fd811a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 296 deletions.
diff --git a/CryptoExchange.Net/CryptoExchange.Net.csproj b/CryptoExchange.Net/CryptoExchange.Net.csproj
@@ -6,12 +6,12 @@
     <PackageId>CryptoExchange.Net</PackageId>
     <Authors>JKorf</Authors>
     <Description>A base package for implementing cryptocurrency exchange API's</Description>
-    <PackageVersion>3.0.11</PackageVersion>
+    <PackageVersion>3.0.12</PackageVersion>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <PackageProjectUrl>https://github.com/JKorf/CryptoExchange.Net</PackageProjectUrl>
     <NeutralLanguage>en</NeutralLanguage>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <PackageReleaseNotes>3.0.11 - Added support for checksum in SymbolOrderBook</PackageReleaseNotes>
+    <PackageReleaseNotes>3.0.12 - Named parameters on SymbolOrderBook events</PackageReleaseNotes>
     <Nullable>enable</Nullable>
     <LangVersion>8.0</LangVersion>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>

diff --git a/CryptoExchange.Net/CryptoExchange.Net.xml b/CryptoExchange.Net/CryptoExchange.Net.xml
diff --git a/CryptoExchange.Net/Objects/Options.cs b/CryptoExchange.Net/Objects/Options.cs
@@ -56,7 +56,6 @@ public class OrderBookOptions : BaseOptions
         /// <param name="sequencesAreConsecutive">Whether each update should have a consecutive id number. Used to identify and reconnect when numbers are skipped.</param>
         /// <param name="strictLevels">Whether or not a level should be removed from the book when it's pushed out of scope of the limit. For example with a book of limit 10,
         /// when a new bid is added which makes the total amount of bids 11, should the last bid entry be removed</param>
-        /// <param name="levels">Amount of levels for this order book</param>
         public OrderBookOptions(string name, bool sequencesAreConsecutive, bool strictLevels)
         {            
             OrderBookName = name;

diff --git a/CryptoExchange.Net/OrderBook/SymbolOrderBook.cs b/CryptoExchange.Net/OrderBook/SymbolOrderBook.cs
@@ -38,7 +38,7 @@ public abstract class SymbolOrderBook : ISymbolOrderBook, IDisposable
         private readonly bool sequencesAreConsecutive;
         private readonly bool strictLevels;
 
-        private Task _processTask;
+        private Task? _processTask;
         private AutoResetEvent _queueEvent;
         private ConcurrentQueue<object> _processQueue;
 
@@ -146,7 +146,7 @@ private class EmptySymbolOrderBookEntry : ISymbolOrderBookEntry
             public decimal Price { get { return 0m; } set {; } }
         }
 
-        private static ISymbolOrderBookEntry emptySymbolOrderBookEntry = new EmptySymbolOrderBookEntry();
+        private static readonly ISymbolOrderBookEntry emptySymbolOrderBookEntry = new EmptySymbolOrderBookEntry();
 
         /// <summary>
         /// The best bid currently in the order book
@@ -284,7 +284,7 @@ public async Task StopAsync()
             log.Write(LogVerbosity.Debug, $"{Id} order book {Symbol} stopping");
             Status = OrderBookStatus.Disconnected;
             _queueEvent.Set();
-            _processTask.Wait();
+            _processTask?.Wait();
             if(subscription != null)
                 await subscription.Close().ConfigureAwait(false);
         }

diff --git a/README.md b/README.md
@@ -199,6 +199,9 @@ The order book will automatically reconnect when the connection is lost and resy
 To stop synchronizing an order book use the `Stop` method.
 
 ## Release notes
+* Version 3.0.12 - 12 Aug 2020
+    * Named parameters on SymbolOrderBook events
+
 * Version 3.0.11 - 20 Jun 2020
 	* Added support for checksum in SymbolOrderBook