Properly assert that release was created in feature test #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@G-Rath looks good, thanks! 🙇 It would be great to avoid the flakiness around midnight, but I can't think of a way to do that without adding a significant amount of complexity. As it stands, the flake scenario should very rarely happen. |
|
@G-Rath wow, you're quick! Thanks for the rebase |
mattbrictson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #2155 (comment) and #2155 (comment)
I've gone with expecting the year, month, day as for that to fail there'd need to be a 24 hour delay between steps which'd be a whole problem of its own - it might be possible that if you run the suite at midnight in a particular timezone it could also fail, but if so that should only be a ~30 second window of possibility...
Short checklist
bundle exec rubocop -ato fix linter issues?Other Information
This is branched off #2159