For fixing issue #160 iOs banner overlapping content on iPhone #249
Conversation
| if let window = UIApplication.shared.keyWindow { | ||
| let safeAreaBottom = window.safeAreaInsets.bottom | ||
| height = height + safeAreaBottom | ||
| } |
There was a problem hiding this comment.
Can you please do not change outside context inside the curly braces?
You can do it with something like
let safeAreaBottom = UIApplication.shared.keyWindow?.safeAreaInsets.bottom ?? 0
height += safeAreaBottom
|
Also please rebase |
|
Hello @looklookson @distante, I think we need to do a rollback for this pull request ( My PR #308 ) because it causes problems when we are on a Banner with a TOP_CENTER position, and it also distorts the Banner's height. I believe we should guide developers towards using a plugin like https://github.com/AlwaysLoveme/capacitor-plugin-safe-area to handle such issues in their JavaScript code rather than coding it natively. Here is also an image showing that it causes problems on iOS and, moreover, I no longer have the same behavior between Android and iOS, which is a bit bothersome. |
I don't suggest to rollback this fix because some user currently use this feature. I suggest to add a option to allow user to disable this feature just in case they don't need it. |
Fixing #160
iOs banner overlapping content on iPhone with rounded corners
iPhones with rounded corners appeared 12 sept of 2018
Since that release date iOs "view" gives a "safeAreaLayoutGuide"