feat: add --skip-host-check flag to start command (#717)

callstack · Apr 16, 2020 · c97ca2b · c97ca2b
1 parent a763588
commit c97ca2b
Show file tree

Hide file tree

Showing 4 changed files with 714 additions and 1 deletion.
diff --git a/packages/haul-cli/src/commands/start.ts b/packages/haul-cli/src/commands/start.ts
@@ -53,6 +53,11 @@ export default function startCommand(runtime: Runtime) {
         default: 'false',
         type: 'string',
       },
+      'skip-host-check': {
+        description: 'Skips check for "index" or "host" bundle in Haul config',
+        default: 'false',
+        type: 'boolean',
+      },
       'max-workers': {
         description:
           'Number of workers used to minify RAM bundle and load modules',
@@ -69,6 +74,7 @@ export default function startCommand(runtime: Runtime) {
         config: string;
         eager: string;
         maxWorkers?: number;
+        skipHostCheck: boolean;
       }>
     ) {
       let parsedEager;
@@ -151,6 +157,7 @@ export default function startCommand(runtime: Runtime) {
           eager: parsedEager,
           platforms: projectConfig.platforms,
           bundleNames: Object.keys(projectConfig.bundles),
+          skipHostCheck: argv.skipHostCheck,
         }).listen(projectConfig.server.host, projectConfig.server.port);
       } catch (error) {
         runtime.logger.error('Command failed with error:', error);

diff --git a/packages/haul-core-legacy/src/compiler/worker/runWebpackCompiler.js b/packages/haul-core-legacy/src/compiler/worker/runWebpackCompiler.js
@@ -48,7 +48,9 @@ module.exports = async function runWebpackCompiler({
   );
 
   const apps = [];
-  const bundles = sortBundlesByDependencies(projectConfig);
+  const bundles = sortBundlesByDependencies(projectConfig, {
+    skipHostCheck: configOptions.skipHostCheck,
+  });
   let totalProgress = 0;
   let bundlesBuilt = 0;
 

diff --git a/packages/haul-core/src/server/Server.ts b/packages/haul-core/src/server/Server.ts
@@ -26,6 +26,7 @@ type ServerEnvOptions = Assign<
     eager: string[];
     bundleNames: string[];
     platforms: string[];
+    skipHostCheck: boolean;
   }
 >;