Added warn msg to terminal output when user changed bundle options (#731

)
callstack · Apr 30, 2020 · 7e23577 · 7e23577
1 parent b6a89b7
commit 7e23577
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/e2e/react_native_0_60x_ts/__tests__/bundleOptions.android.test.ts b/e2e/react_native_0_60x_ts/__tests__/bundleOptions.android.test.ts
@@ -37,7 +37,7 @@ describe('packager server', () => {
 
     expect(responseAfterBundleOptionsChanged.status).toBe(501);
     expect(minifiedSecondBundle.toString()).toBe(
-      'To see the changes you need to restart the haul server'
+      'Changing query params after the bundle has been created is not supported. To see the changes you need to restart the Haul server.'
     );
 
     stopServer(instance);

diff --git a/e2e/react_native_0_60x_ts/__tests__/bundleOptions.ios.test.ts b/e2e/react_native_0_60x_ts/__tests__/bundleOptions.ios.test.ts
@@ -37,7 +37,7 @@ describe('packager server', () => {
 
     expect(responseAfterBundleOptionsChanged.status).toBe(501);
     expect(minifiedSecondBundle.toString()).toBe(
-      'To see the changes you need to restart the haul server'
+      'Changing query params after the bundle has been created is not supported. To see the changes you need to restart the Haul server.'
     );
 
     stopServer(instance);

diff --git a/packages/haul-core/src/server/setupCompilerRoutes.ts b/packages/haul-core/src/server/setupCompilerRoutes.ts
@@ -110,9 +110,10 @@ export default function setupCompilerRoutes(
         );
 
         if (isUserChangedOptions) {
-          return h
-            .response('To see the changes you need to restart the haul server')
-            .code(501);
+          const warnMsg =
+            'Changing query params after the bundle has been created is not supported. To see the changes you need to restart the Haul server.';
+          runtime.logger.warn(warnMsg);
+          return h.response(warnMsg).code(501);
         }
 
         if (areBundleOptionsSet(bundleOptionsFromQuery)) {