Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x native datetime #12934

Merged
merged 13 commits into from
Feb 12, 2019
Merged

4.x native datetime #12934

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e88d4c9
Modify DateTimeWidget to generate native HTML date/time inputs.
ADmad Dec 17, 2018
0589e0e
Update FormHelper's datetime methods.
ADmad Jan 28, 2019
0272f8b
Add YearWidget for generation selectboxes for years.
ADmad Jan 28, 2019
3974f5c
Simply year range generation.
ADmad Jan 29, 2019
ddebf2c
Include seconds for time input value.
ADmad Feb 3, 2019
0f2deb5
Include seconds for datetime-locl input value.
ADmad Feb 3, 2019
a649730
Allow specifying timezone when generating values for datetime input.
ADmad Feb 3, 2019
50d2add
Don't always set value for current datetime.
ADmad Feb 4, 2019
69d753a
Remove code for generating individual datetime selects.
ADmad Feb 4, 2019
f9c1faf
Update docblocks.
ADmad Feb 4, 2019
1fbb267
Fix CS errors.
ADmad Feb 4, 2019
744734a
Add format used by HTML datetime input to DateTimeType.
ADmad Feb 4, 2019
f5bd76a
Fix CS errors.
ADmad Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include seconds for time input value.
  • Loading branch information
@ADmad
ADmad committed Feb 3, 2019
commit ddebf2c9ff708f5d66fc485942e7e1bbf39a6880
2 changes: 1 addition & 1 deletion src/View/Widget/DateTimeWidget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class DateTimeWidget implements WidgetInterface
protected $formatMap = [
'datetime-local' => 'Y-m-d\TH:i',
'date' => 'Y-m-d',
'time' => 'H:i',
'time' => 'H:i:s',
'month' => 'Y-m',
'week' => 'Y-\WW',
];
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase/View/Helper/FormHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6054,7 +6054,7 @@ public function testTime()
'input' => [
'type' => 'time',
'name' => 'start_time',
'value' => '16:30',
'value' => '16:30:00',
],
];
$this->assertHtml($expected, $result);
Expand Down