Add a Leave Channel button to PM page #326
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cabal-client with the leaving functionality has been released, it's 7.3.0 :) cc @khubo @nikolaiwarner: i tested it out in cabal-cli and i didn't need to add anything specific to make the leaving work as intended, at least not anything in cabal-cli! i patched cabal-client a bit to make things work tho, but that's in the release mentioned above :3 thanks again @dchiquito! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on the release of cabal-club/cabal-client#87 so the cabal-client dependency can also be bumped.
For some reason it isn't working when I test it locally and I can't get the electron devtools to open up so I can debug it, so it's probable that there's a dumb typo somewhere.