Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split extension capabilities in BuildServerCapabilities #609

Open
agluszak opened this issue Sep 19, 2023 · 2 comments
Open

Split extension capabilities in BuildServerCapabilities #609

agluszak opened this issue Sep 19, 2023 · 2 comments

Comments

@agluszak
Copy link
Collaborator

agluszak commented Sep 19, 2023 •
edited
Loading

It seems this BuildServerCapabilities is dependent on all extensions. In the future it may be worth splitting into many extension capabilities. It could look like this:

structure BuildServerCapabilities {
  /// common providers

  extensionCapabilities: Map[String, ExtensionCapabilities]
}

Originally posted by @adpi2 in #580 (comment)
@agluszak agluszak mentioned this issue Sep 19, 2023
Merged
@jastice
Copy link
Member

jastice commented Sep 19, 2023

A JSON object is a map string->object anyway. It would be cleaner if we had one object per extension, so I agree with the general idea here. But if the extension is known in this repo, the keys for capability should be explicit rather than arbitrary strings.

@lefou
Copy link
Contributor

lefou commented May 31, 2024

I like and support the idea. It would make it easier to piggyback on BSP with non-official extentions, e.g. to test them out before formalizing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jastice @lefou @agluszak