-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename InitializeBuildParams to BuildInitializeParams (same for ShutdownBuildParams) #562
Comments
Agree, let's keep naming consistent.
Not sure I agree. Naming is based on json-rpc method names. To change it we'd have to change the protocol. I think the rationale for this name is that |
Agreed |
With the introduction of Base Protocol, this still would make sense to do (but maybe in the next version of the protocol). See https://microsoft.github.io/language-server-protocol/specifications/base/0.9/specification/#initialize |
Params of methods "build/initialize" and "build/shutdown" are named "InitializeBuildParams" and "ShutdownBuildParams", so to keep things consistent we should rename the params. All other params are named "${methodName}Params}".
BTW, I think we should remove the "build" part of it altogether, because these methods are not related in any way to building. They are related to the lifetime of the server.
The text was updated successfully, but these errors were encountered: