-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support something similar to 'workspace/didChangeConfiguration' in LSP #546
Comments
We already have the workspace/reload request to instruct the server to reload the configuration. Isn't that what you need? What is the difference? |
The gap is that, we cannot put the value of the settings as the request body of Maybe take a deep look of the Gradle Tooling API can better illustrate the issue: https://docs.gradle.org/current/javadoc/org/gradle/tooling/GradleConnector.html#connect-- From the API, you can find some method like useGradleUserHomeDir(), useGradleVersion(), etc... Imagine that in the IDE, there will be some setting fields to let user specify the Gradle user home dir or Gradle version, then we need a mechanism to let build server know those settings. Meanwhile, when user updates them, a notification needs to be sent to the build server. The notification should contain the new values of those settings - because there is no way to let the build server ask it from client either. |
Thanks for the clarification. Would it solve the issue if we add a |
Yes, but might not be the best? Just my personal understanding of While for the settings, they are different things compare to the configuration files like |
Describe the use-case for this feature
Suppose that the Build Server is talking to Gradle daemon. Users can specify some settings like The JDK used to launch the daemon, and some arguments when using the Tooling API.
Now there is no BSP request that can notify the server some of the settings has been changed.
What do you propose
Introduce a new request that notifys that some settings has been changed. Similar to https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#workspace_didChangeConfiguration
I've checked to make sure there isn't already a way to support this in the current protocol
Maintainer approval (This is for the maintainers)
The text was updated successfully, but these errors were encountered: