Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Minor inconsistencies discovered during the smithy migration #506

Open
3 of 7 tasks
agluszak opened this issue Apr 22, 2023 · 1 comment
Open
3 of 7 tasks

WIP: Minor inconsistencies discovered during the smithy migration #506

agluszak opened this issue Apr 22, 2023 · 1 comment

Comments

@agluszak
Copy link
Collaborator

agluszak commented Apr 22, 2023 •
edited
Loading

  • Sometimes we use a map for passing environment variables (https://build-server-protocol.github.io/docs/extensions/jvm#test-environment-request), sometimes we use a list (https://build-server-protocol.github.io/docs/extensions/scala#scala-specific-data-kinds-for-debugging)
  • JVM environment requests include an originId. Why?
  • Scala test classes request also has an originId (both in params and respons)
  • framework field in ScalaTestClassesItem is marked as optional, but with an annotation "It's optional in order to maintain compatibility, however it is expected from the newer implementations to not leave that field unspecified.". Let's make it obligatory then.
  • buildTarget/inverseSources in should be called textDocument/inverseSources
  • split TaskData into TaskStartData, TaskProgressData and TaskFinishData
  • a field is called className in ScalaTestSuiteSelection while the same field is serialized to class in ScalaMainClass
@agluszak
Copy link
Collaborator Author

Related: #562

@agluszak agluszak mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agluszak