I believe we also discussed dropping this request completely? Does any client use it?

I believe we also discussed dropping this request completely?

I confirm. Let's drop it!

Metals does use it currently https://github.com/scalameta/metals/blob/main/metals/src/main/scala/scala/meta/internal/metals/BuildServerConnection.scala#L254

Why would it be neccessary to drop it?

This was introduced in scalameta/metals@d9eb419 I presume needed for large Scala codebase initialy written in pants.

This was introduced in scalameta/metals@d9eb419 I presume needed for large Scala codebase initialy written in pants.

So it seems we need it in Metals because Bloop/Pants can use glob patterns in their configurations to define source files. Maybe if we add glob pattern support in buildTarget/sources we don't need textDocument/inverseSources anymore.

I guess globbing is something we'll want to add at some point to all requests

Maybe if we add glob pattern support in buildTarget/sources we don't need textDocument/inverseSources anymore.

if a server returns a dir as a source and user adds a file under this dir from the client pov this new file is under this build target
it is possible that it was just a coincidence and the build target actually doesnt want to include this new file (for example very funkly glob), Anyway textDocument /inverseSources doesnt solve this issue at all, since the state of "normal" sources will be broken then as well - it's more about when and how should we "reload" the state