Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go protobuf library #3594

Merged
merged 8 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add testcase
  • Loading branch information
emcfarlane committed Jan 15, 2025
commit 37c005f92113d5bc76ddafac095b51d2ae3fd0fe
4 changes: 2 additions & 2 deletions make/go/dep_protoc.mk
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ $(call _assert_var,CACHE_INCLUDE)
$(call _assert_var,CACHE_BIN)

# Settable
# https://github.com/protocolbuffers/protobuf/releases 20241204 checked 20241217
# https://github.com/protocolbuffers/protobuf/releases 20250108 checked 20250115
# NOTE: Set to version compatible with genproto source code (only used in tests).
PROTOC_VERSION ?= 29.1
PROTOC_VERSION ?= 29.3

# Google adds a dash to release candidate versions in the name of the
# release artifact, i.e. v27.0-rc1 -> v27.0-rc-1
Expand Down
9 changes: 9 additions & 0 deletions private/bufpkg/bufcheck/lint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1270,6 +1270,15 @@ func TestRunLintCustomWasmPlugins(t *testing.T) {
)
}

func TestRunLintEditionsGoFeatures(t *testing.T) {
t.Parallel()
testLint(
t,
"editions_go_features",
bufanalysistesting.NewFileAnnotationNoLocation(t, "a.proto", "PACKAGE_DEFINED"),
)
}

func testLint(
t *testing.T,
relDirPath string,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
edition = "2023";

import "google/protobuf/go_features.proto";

option features.(pb.go).api_level = API_OPAQUE;
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
version: v1
lint:
use:
- PACKAGE_DEFINED
2 changes: 1 addition & 1 deletion private/gen/data/datawkt/datawkt.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading