Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v2.0.1 add sudo and docker support #27

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

btungut
Copy link
Owner

@btungut btungut commented Dec 24, 2024

This pull request includes changes to the Dockerfile and the start.sh script to improve the setup process and ensure proper permissions for the azdouser user. The most important changes are grouped by theme below:

Dockerfile Improvements:

  • Updated the Dockerfile to install sudo and modify the sudoers file to allow azdouser to execute commands without a password.
  • Changed ownership commands to use sudo to ensure azdouser has the correct permissions on directories and the Docker socket.

Start Script Enhancements:

  • Added a check in start.sh to verify if sudo is available and use it to set appropriate ownership and group permissions for azdouser.
  • Included logic in start.sh to handle the Docker socket, ensuring azdouser is added to the docker group if the socket exists.

@btungut btungut self-assigned this Dec 24, 2024
@btungut btungut marked this pull request as ready for review December 24, 2024 23:09
@btungut btungut linked an issue Dec 24, 2024 that may be closed by this pull request
@btungut btungut changed the base branch from master to release/v2.1.0 December 24, 2024 23:21
@btungut btungut merged commit 2c8c5ef into release/v2.1.0 Dec 24, 2024
btungut added a commit that referenced this pull request Dec 24, 2024
* Feature/v2.0.1 add sudo and docker support (#27)

* Update Dockerfile to install sudo and adjust ownership commands for azdouser

* Add ownership and group management for azdouser in start.sh before checking the command sudo is available

* Bump version to 2.1.0 and update Docker image tag to 3.248.0-stable-v2.1.0 in README and values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending agent is not working. Sudo is missing.
1 participant