Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcutil: Add library functions for BIP-0352 silent payment _send_ support #2244

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Sep 1, 2024

Still work in progress, test vectors aren't passing yet.

Goal is to address send support first as that's rather straightforward. Receive support is much more involved as it requires scanning the chain in a specific manner.

@coveralls
Copy link

coveralls commented Oct 20, 2024

Pull Request Test Coverage Report for Build 12557281611

Details

  • 408 of 732 (55.74%) changed or added relevant lines in 8 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 57.225%

Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/silentpayments/output.go 52 58 89.66%
btcutil/silentpayments/secp.go 40 51 78.43%
btcutil/psbt/partial_output.go 1 17 5.88%
btcutil/silentpayments/input.go 81 102 79.41%
btcutil/silentpayments/dleq.go 104 131 79.39%
btcutil/psbt/psbt.go 31 65 47.69%
btcutil/silentpayments/address.go 99 183 54.1%
btcutil/psbt/silentpayments.go 0 125 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 6 74.16%
Totals Coverage Status
Change from base Build 12401774722: -0.04%
Covered Lines: 30297
Relevant Lines: 52944

💛 - Coveralls

@guggero guggero force-pushed the silent-payments branch 3 times, most recently from edef016 to 2a9a931 Compare December 29, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants