Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire, netsync: change isSyncCandidate behavior #2035

Merged
merged 3 commits into from
Dec 9, 2023
Merged

wire, netsync: change isSyncCandidate behavior #2035

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1012f1e
wire: add NodeNetworkLimitedBlockThreshold const
kcalvinalvin Sep 25, 2023
a09e7b2
wire: add HasFlag method
kcalvinalvin Nov 7, 2023
b4992fe
netsync: change isSyncCandidate behavior to include pruned nodes
kcalvinalvin Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
wire: add NodeNetworkLimitedBlockThreshold const 
NodeNetworkLimitedBlockThreshold is a constant representing how many
blocks from tip a node signaling NODE_NETWORK_LIMITED must serve.
  • Loading branch information
@kcalvinalvin
kcalvinalvin committed Sep 25, 2023
commit 1012f1e4ba3176c29c18843c01246a9fe1ae5acf
6 changes: 6 additions & 0 deletions wire/protocol.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@ func (f ServiceFlag) String() string {
return s
}

const (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: declare up with the service flags? This location seems a bit arbitrary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

// NodeNetworkLimitedBlockThreshold is the number of blocks that a node
// broadcasting SFNodeNetworkLimited MUST be able to serve from the tip.
NodeNetworkLimitedBlockThreshold = 288
)

// BitcoinNet represents which bitcoin network a message belongs to.
type BitcoinNet uint32

Expand Down