Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sighash taproot keyspend bug fix #1941

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Sighash taproot keyspend bug fix #1941

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6e8292
txscript: fix sighash bug in RawTxInTaprootSignature
Roasbeef Jan 24, 2023
5e0de1c
txscript: add new PayToTaprootScript function
Roasbeef Jan 25, 2023
d6efaa7
txscript: add tests for RawTxInTaprootSignature and RawTxInTapscriptS…
Roasbeef Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
txscript: fix sighash bug in RawTxInTaprootSignature 
In this commit, we fix a bug in RawTxInTaprootSignature that would cause
the function to not properly apply the sighash flag for non-default
sighash signatures. The logic would end up applying `0x00` as a mask,
which will always be `0x00` on the other end.

The RawTxInTapscriptSignature function was correct, though it had the
ordering switched as it applies the sighash if the type doesn't equal
default.
  • Loading branch information
@Roasbeef
Roasbeef committed Jan 25, 2023
commit f6e8292402f5c4466b3f8b41f259d0457d5ec715
2 changes: 1 addition & 1 deletion txscript/sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func RawTxInTaprootSignature(tx *wire.MsgTx, sigHashes *TxSigHashes, idx int,

// If this is sighash default, then we can just return the signature
// directly.
if hashType&SigHashDefault == SigHashDefault {
if hashType == SigHashDefault {
return sig, nil
}

Expand Down