Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: sendrawtransaction is broken #1647

Closed
torkelrogstad opened this issue Oct 6, 2020 · 2 comments
Closed

rpcclient: sendrawtransaction is broken #1647

torkelrogstad opened this issue Oct 6, 2020 · 2 comments

Comments

@torkelrogstad
Copy link
Contributor

It is not possible to use sendrawtransaction with the current RPC client (0.21) and Bitcoin Core (0.20, believe this applies to 0.19) as well. This regression was introduced in #1484.

The underlying issue is that Bitcoin Core expects two arguments to the RPC call, and the current implementation leads to three.

I tried to fix this on my side by adding two different structs, one for pre- and post 0.19. I then ran into a blocker, where we can only register one struct per command.

It seems like this was attempted fixed in #1415. I'd say that this is a pretty high priority issue. I can work around it for now by using a fork, but that's not ideal.
torkelrogstad added a commit to arcanetechnology/btcd that referenced this issue Oct 6, 2020
@torkelrogstad
fix btcsuite#1647
04887b1 
See btcsuite#1647 for context
@torkelrogstad
Copy link
Contributor Author

Here's my fix, if anyone's interested: 04887b1

@torkelrogstad
Copy link
Contributor Author

Sorry, this was doubly opened by a mistake. #1646 is the proper issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@torkelrogstad