This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Remove built in support of css modules in favor of postcss-brunch #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2016
|
Excellent. Thanks. Can't wait for the PR to be merged. |
|
Don't bump the version. Keep it 2.9.0. Just mention in the readme that users would need to downgrade to 2.6. |
|
I changed my commit to bump only to 2.9.0 |
|
Thanks! |
|
But before merging this, I need to find a solution for brunch/postcss-brunch#33 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With brunch/postcss-brunch#33
should fix #124
Even if not absolutely required for it to work, I think it is good to drop this code.
I made some tests with
postcss-brunchandsass-brunchand everything works (modules and autoprefixer).I think a test suite that test
sass-brunchwithpostcss-brunchand a few processors should live somewhere. I don't know in what repo to put it as neither are absolutely dependent on the other.I bumped the version because this might break backward compatibility.