Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brody personal ci testing for no-std support in naga #1

Draft
wants to merge 34 commits into
base: trunk
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
cb81b76
no-std support in naga
brody4hire Jan 17, 2025
af03315
Merge branch 'trunk' of https://github.com/gfx-rs/wgpu into no-std-su…
brody4hire Jan 19, 2025
d384d26
no-std clippy check for naga
brody4hire Jan 19, 2025
ed241c3
start CI testing with no std features
brody4hire Jan 19, 2025
e610a43
Merge branch 'trunk' of https://github.com/gfx-rs/wgpu into no-std-su…
brody4hire Jan 19, 2025
136206d
fixup no-std feature test CI task
brody4hire Jan 19, 2025
2cd4f23
update no-std feature test comment in ci.yml
brody4hire Jan 19, 2025
e4ec12a
fixup no-std build - partial fixup with XXX TODO remaining in naga/sr…
brody4hire Jan 19, 2025
cca6cef
fixup naga/tests/snapshots.rs
brody4hire Jan 19, 2025
b078c6c
additional fixup: naga/src/proc/constant_evaluator.rs
brody4hire Jan 19, 2025
e143422
XXX UPDATE: wgpu-hal/src/gles/device.rs
brody4hire Jan 19, 2025
24e1f0d
XXX TODO in ci.yml
brody4hire Jan 19, 2025
b650dfe
remove import not needed: borrow::ToOwned
brody4hire Jan 19, 2025
141b1cd
fixup fmt: naga/src/proc/constant_evaluator.rs
brody4hire Jan 19, 2025
2384b13
fixup fmt etc: naga/src/lib.rs
brody4hire Jan 19, 2025
a5a963d
use #[allow(unused_imports] as quick workaround to avoid failures wit…
brody4hire Jan 19, 2025
c80ae2f
fixup: use naga::FastHashMap in wgpu-hal
brody4hire Jan 19, 2025
e51f78d
XXX temporary build fixup: wgpu-hal/src/vulkan/device.rs
brody4hire Jan 19, 2025
45efdf2
XXX TBD std feature gate for front::wgsl::parse::directive
brody4hire Jan 19, 2025
ad325dc
fixup feature spec for std & multiple dependencies
brody4hire Jan 20, 2025
d706eae
update feature spec for feature: glsl-in
brody4hire Jan 20, 2025
b2964a9
Merge branch 'trunk' of https://github.com/gfx-rs/wgpu into no-std-su…
brody4hire Jan 20, 2025
6a095af
support dot-out with no-std
brody4hire Jan 20, 2025
a5f2aae
update CI to test dot-out with no-std (etc)
brody4hire Jan 20, 2025
3a62d43
support glsl-out with no-std
brody4hire Jan 20, 2025
d9e05fe
fixup: ignore unused imports for now in aliases::std
brody4hire Jan 20, 2025
ace1de4
support msl-out with no-std
brody4hire Jan 20, 2025
c73bd2f
Move Examples to Subfolder
cwfitzgerald Jan 4, 2025
43b6637
Remove Hello Example
cwfitzgerald Jan 4, 2025
7fccb6b
Standalone Compute
cwfitzgerald Jan 5, 2025
04e40dd
Update Vulkan SDK (#6955)
cwfitzgerald Jan 21, 2025
b9f0c9b
require std for naga remaining features (for now at least); update XX…
brody4hire Jan 21, 2025
7574eca
Merge branch 'trunk' of https://github.com/gfx-rs/wgpu into no-std-su…
brody4hire Jan 21, 2025
aed9f7e
remove outdated XXX TODO comment from ci.yml
brody4hire Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup fmt: naga/src/proc/constant_evaluator.rs
  • Loading branch information
brody4hire committed Jan 19, 2025
commit 141b1cd9c243bea2fca404e686eb32e089dee72f
2 changes: 1 addition & 1 deletion naga/src/proc/constant_evaluator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ impl<'a> ConstantEvaluator<'a> {
// - https://github.com/rust-num/num-traits/blob/num-traits-0.2.19/src/float.rs#L1905
// (with compatible licensing as well)
#[inline]
fn with_sign(magnitude :f64, with_negative_sign: bool) -> f64 {
fn with_sign(magnitude: f64, with_negative_sign: bool) -> f64 {
if with_negative_sign {
-magnitude.abs()
} else {
Expand Down