-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BW-1317 Upgrade googleCloudNioV
to latest
#6804
Conversation
// BW-808 Pinning googleCloudNioV to this tried-and-true old version and quieting Scala Steward. | ||
// 0.121.2 is the most recent version currently known to work. | ||
private val googleCloudNioV = "0.61.0-alpha" // scala-steward:off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always makes me a little uneasy deleting "danger!" comments but we do have a test and the proof of the pudding will be in the eating
Documenting my review process here. For dependency updates, I like to review the changelog. In this case, we're going from
In summary, it's probably safe to go all the way to the most recent version. In fact, my gut feeling is that the risk is low enough to be outweighed by the benefit of being up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love @breilly2 's analysis. 👍 from me.
Likewise, thank you @breilly2 for the analysis! |
Last time we tried to upgrade this we ran into a bug, but it has now been fixed and we have a unit test for the library that verifies the fix.
Besides generally keeping important libraries up to date, there is a chance that recent fixes to requester pays (Google PR, GATK PR) implemented by our own very Methods team may solve an issue users are seeing in Terra:
Terra User Liaison Slack link.
DSP Methods Slack link.