Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Code to Visualize Example Images #122

Merged
merged 19 commits into from
Apr 1, 2020

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Apr 1, 2020

I add code that is modified from https://github.com/jr0th/segmentation/blob/master/visualization/CellArt.ipynb and using input from @MarziehHaghighi to visualize example cell painting images

greyscale_channel

color_merged

I will use these images in an updated Figure 1A.

Updating Cell Colors

I also updated cell colors in this PR. This should have probably been a different PR. I will update cell line colors again after feedback from special topics (too similar to other palette could be somewhat confusing/misleading)

@gwaybio gwaybio merged commit fc4735b into broadinstitute:master Apr 1, 2020
@gwaybio gwaybio deleted the sample-images branch April 1, 2020 21:41
@shntnu
Copy link
Collaborator

shntnu commented Apr 1, 2020

Love it!

@shntnu
Copy link
Collaborator

shntnu commented Apr 1, 2020

The one issue with the logic (IIUC it correctly) is that it rescales each image, so that makes it hard to compare one image with another.

@gwaybio
Copy link
Member Author

gwaybio commented Apr 2, 2020

oh, i realized I should tag @jr0th - thanks for making your code public and reusable!

@jr0th
Copy link

jr0th commented Apr 2, 2020

Sure thing! What an honor!

@gwaybio
Copy link
Member Author

gwaybio commented Apr 2, 2020

The honor is mine!

I added jr0th/segmentation#7 where I strongly recommend that you add a license to this body of work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants